Skip to content

N°8545 - Standardize return message from password reset#812

Merged
steffunky merged 8 commits intosupport/3.2from
issue/8545-standardize-return-message
Feb 19, 2026
Merged

N°8545 - Standardize return message from password reset#812
steffunky merged 8 commits intosupport/3.2from
issue/8545-standardize-return-message

Conversation

@steffunky
Copy link
Member

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N°8545
Type of change? Enhancement

Objective (enhancement)

Standardize message returned to the user in the reset password form. Log the real results in the log file.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances security by preventing user enumeration attacks in the password reset functionality. The change ensures that all password reset requests receive the same standardized success message regardless of whether the user exists or errors occur, while actual failure reasons are logged server-side for administrator review.

Changes:

  • Modified the ForgotPwdGo() exception handling to always display a generic success message
  • Added server-side logging of password reset failures with user context
  • Prevented exposure of sensitive information (user existence, configuration errors) to end users

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@steffunky steffunky changed the base branch from develop to support/3.2 February 19, 2026 14:12
steffunky and others added 4 commits February 19, 2026 15:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@eespie eespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok pour moi

@steffunky steffunky merged commit 9fd0ffd into support/3.2 Feb 19, 2026
@steffunky steffunky deleted the issue/8545-standardize-return-message branch February 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants