Add: shouldCloseEditor prop#2722
Closed
blancham wants to merge 10 commits intoComcast:mainfrom
Closed
Conversation
fixed resizable columns, fixed auto support
Collaborator
|
Thank you for the PR. We have added a new prop to handle this scenario |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
React-data-grid works great in a local environment but when it comes to use it with a database, problems appear...
Imagine you have 2 tables on two different laptops. With the current implementation, if I'm editing a cell and that the other guy is modifying the grid data, my cell editor will be closed automatically independently of what row/ cell has been edited.
Solution
shouldCloseEditoris a function and allows you to specify the behaviour when you are editing a cell and that new data comes from the outside of the table.In my project, I close the editor only when the value of the cell I'm currently editing has changed.