Skip to content

Add editorOptions.closeOnExternalRowChange prop#3759

Merged
amanmahajan7 merged 8 commits intomainfrom
am-discardOnRowChange
Apr 16, 2025
Merged

Add editorOptions.closeOnExternalRowChange prop#3759
amanmahajan7 merged 8 commits intomainfrom
am-discardOnRowChange

Conversation

@amanmahajan7
Copy link
Copy Markdown
Collaborator

Fixes #3205

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (c4f4de8) to head (d97c6c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3759      +/-   ##
==========================================
+ Coverage   98.69%   98.81%   +0.11%     
==========================================
  Files          47       47              
  Lines        3456     3460       +4     
  Branches      750      752       +2     
==========================================
+ Hits         3411     3419       +8     
+ Misses         45       41       -4     
Files with missing lines Coverage Δ
src/DataGrid.tsx 99.77% <100.00%> (+<0.01%) ⬆️
src/EditCell.tsx 98.13% <100.00%> (ø)
src/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanmahajan7 amanmahajan7 marked this pull request as ready for review April 15, 2025 23:14
@amanmahajan7 amanmahajan7 requested a review from nstepien as a code owner April 15, 2025 23:14
Comment thread src/types.ts Outdated
Comment thread src/DataGrid.tsx Outdated
Comment thread src/types.ts Outdated
@amanmahajan7 amanmahajan7 changed the title Add editorOptions.discardOnRowChange prop Add editorOptions.closeOnExternalRowChange prop Apr 16, 2025
@amanmahajan7 amanmahajan7 requested a review from nstepien April 16, 2025 13:41
nstepien
nstepien previously approved these changes Apr 16, 2025
Comment thread test/browser/column/renderEditCell.test.tsx Outdated
Comment thread test/browser/column/renderEditCell.test.tsx Outdated
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
@amanmahajan7 amanmahajan7 merged commit de086c9 into main Apr 16, 2025
2 checks passed
@amanmahajan7 amanmahajan7 deleted the am-discardOnRowChange branch April 16, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor is immeditely closed when a row is updated

2 participants