Bundle include and libs folders in the portable release#7200
Open
woct0rdho wants to merge 2 commits intoComfy-Org:masterfrom
Open
Bundle include and libs folders in the portable release#7200woct0rdho wants to merge 2 commits intoComfy-Org:masterfrom
include and libs folders in the portable release#7200woct0rdho wants to merge 2 commits intoComfy-Org:masterfrom
Conversation
woct0rdho
requested review from
Kosinkadink,
huchenlei,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
|
this should be merged uv also correctly creates relocatable, self contained environments for windows, maybe it's worth migrating to that. it can easily be named |
Member
|
@Kosinkadink Do you think this can be merged? |
Member
Test Evidence CheckIf this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided. You can add it by:
|
Contributor
Author
|
I don't think this PR changes any user-facing behavior. Previously we were letting the user do the developer's work. |
Kosinkadink
added
For PR Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by JIT compilation such as Triton, see https://github.com/woct0rdho/triton-windows#8-special-notes-for-comfyui-with-embeded-python
Because of the increasing popularity of Triton, I think it's needed to bundle the two folders in the ComfyUI portable release so it's easier for users to install Triton. This should be done at the level of Python distribution, rather than a pip package.
On Windows, the two folders are not bundled in the Python embed distribution, and the standard way to obtain them is nuget, see https://bugs.python.org/issue38224 and https://docs.python.org/3/using/windows.html . This is also what cibuildwheel does. There is no notable difference from python-build-standalone.
I've tested that the workflow runs successfully at https://github.com/woct0rdho/ComfyUI/releases/tag/test-nuget , and in this portable release Triton works without manually copying the two folders.
The two folders only take ~2 MB uncompressed, so this almost does not impact the overall package size.
Note that the nuget API may produce HTTP 302 redirect to some CDN, so we need
curl --location