chore(hygiene): drop org-qualified private repo paths from two docstrings - #767
chore(hygiene): drop org-qualified private repo paths from two docstrings#767mattmillerai wants to merge 1 commit into
Conversation
…ings Both were prose provenance notes that named a private repo by its full org/name path. The unqualified names they describe already appear elsewhere in the same files and are not what the hygiene check denies, so the fact survives and the path does not.
dosubot
Bot
added
size:XS
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 116 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
✅ No high-signal findings.
Panel: 8/8 reviewers contributed findings.
|
Superseded by #768, which collapses this with the private-source-coordinate move and the gallery-fixture exclusion so a single PR demonstrates a green hygiene check. The docstring commit is carried over unchanged. |
1 participant
Summary
Two docstrings carried a provenance note that named a private repo by its full
org/namepath. Neither path was doing any work: the unqualified names they describe already appear elsewhere in the same files, and an unqualified name is not what the hygiene check denies. The fact survives, the path does not.comfy_cli/cql/engine.py: the port-provenance line now names the Go package without the repo path.comfy_cli/knowledge.py: the bundle producer is now described by pipeline rather than by repo path.Comments only, no behaviour change.
Testing
ruff format --checkandruff checkclean on both files.tests/comfy_cli/cql/passes, 337 tests.Note on the remaining findings
This clears 2 of the repo's 29 hygiene findings. Of the rest, 19 are public model download URLs that the checker was misreading as GitHub references, fixed upstream in Comfy-Org/github-workflows#217, and 8 are a genuine private-repo reference in
.github/workflows/refresh-cql-catalogs.ymlthat needs a design decision rather than a scrub, since the workflow authenticates against that repo and the name is load-bearing. Two markdown link texts in a captured upstream test fixture also remain and are correctly denied.