Skip to content

chore: public-repo hygiene check passes on main - #785

Merged
skishore23 merged 1 commit into
mainfrom
skishore23/public-repo-hygiene
Aug 26, 2026
Merged

chore: public-repo hygiene check passes on main#785
skishore23 merged 1 commit into
mainfrom
skishore23/public-repo-hygiene

Conversation

@skishore23

Copy link
Copy Markdown
Contributor

Summary

The hygiene / public-repo-hygiene check (Comfy-Org/github-workflows reusable
workflow, pinned at 609f9729…) has been red on main, so every PR shows red.
Findings and disposition:

  • comfy_cli/cql/engine.py:7, comfy_cli/knowledge.py:4 — source comments
    named two private Comfy-Org GitHub repos (cql, comfy-knowledge) by
    string. Reworded to describe what they are ("the Go reference engine", "the
    curated knowledge bundle repo") instead of naming them. No behavior change.

  • .github/workflows/refresh-cql-catalogs.yml (8 lines) — this workflow
    genuinely, intentionally clones/reads the private cloud repo to fetch
    no_gpu_nodes.json. That's the point of the workflow, not a leak, so it's
    now in exclude_paths with a comment explaining why.

  • comfy_cli/command/run/preflight.py:176, tests/e2e/test_e2e.py:344
    real huggingface.co/Comfy-Org/stable-diffusion-v1-5-archive model download
    URLs. I checked the checker source
    (check_public_repo_hygiene.py): it has no Hugging Face allowlist — its
    Comfy-Org/<name> pattern matches the literal string regardless of the
    surrounding URL/host, so a fully-qualified HF URL does not clear it (and
    preflight.py:176 was already a full URL, confirming this). The HF repo
    can't go in the checker's allowlist either — that list is GitHub repos
    only and is org-owned, not settable from this repo. Excluded both files,
    with a comment explaining the HF-vs-GitHub root cause.

  • tests/comfy_cli/fixtures/** (gallery + sd15_ui_workflow.json) —
    verbatim gallery/workflow template fixtures; several embed
    Comfy-Org/<huggingface-model-repo> strings (Qwen-Image, ACE-Step) for the
    same HF-vs-GitHub reason above. These must stay byte-for-byte identical to
    the real templates, so excluded rather than edited.

  • HALO-03 (test_knowledge_attach.py:146, test_knowledge.py:495) —
    fictional product id used as test fixture data, not a real ticket. Added to
    ticket_allowlist alongside the existing HAILUO-03.

All changes are in .github/workflows/public-repo-hygiene.yml (ticket
allowlist + exclude_paths, each with an explanatory comment) plus the two
docstring rewordings. No fixture files were edited.

Test plan

  • Ran the checker locally exactly as CI invokes it (root ., same
    --exclude/--ticket-allow values now in the workflow):
    Result: no internal-only references found. (exit 0; 457 files
    scanned, 4 exclusion entries matched 17 files total, 0 findings)
  • uvx ruff@0.15.15 check . — all checks passed
  • pytest tests/comfy_cli/test_knowledge.py tests/comfy_cli/test_knowledge_attach.py tests/comfy_cli/cql/test_engine.py tests/comfy_cli/test_run_execution_lifecycle.py — 355 passed

Reword two docstrings that named private repos by string (comfy-cli/cql
and comfy-knowledge), add HALO-03 to the ticket allowlist (fixture data,
not a real ticket), and exclude the paths whose real Comfy-Org/<repo>
references the checker can never resolve: refresh-cql-catalogs.yml
(intentionally reads the private cloud repo), the gallery/workflow
fixtures (verbatim Hugging Face model repo names), and the two files
with a real huggingface.co/Comfy-Org/... download URL.
@skishore23
skishore23 requested a review from annehe9 August 26, 2026 00:24
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dfa2a2ce-356d-41db-84eb-a3691c6cfc78

📥 Commits

Reviewing files that changed from the base of the PR and between fa52ded and c746603.

📒 Files selected for processing (3)
  • .github/workflows/public-repo-hygiene.yml
  • comfy_cli/cql/engine.py
  • comfy_cli/knowledge.py

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The pull request updates the public repository hygiene workflow and revises provenance descriptions in the CQL engine and knowledge bundle modules.

Changes

Repository hygiene and provenance

Layer / File(s) Summary
Hygiene checker allowlist and exclusions
.github/workflows/public-repo-hygiene.yml
The workflow allowlists HALO-03 and excludes known legitimate references and test fixture paths.
Module provenance descriptions
comfy_cli/cql/engine.py, comfy_cli/knowledge.py
The module docstrings use updated descriptions for their source repositories and packages.

Suggested reviewers: annehe9

Merge Risk: ⚪ Minimal · up to c7466

This PR updates repository hygiene exclusions and rewords two source comments without changing runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skishore23/public-repo-hygiene
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch skishore23/public-repo-hygiene

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 26, 2026
@skishore23
skishore23 merged commit 3fa2f55 into main Aug 26, 2026
20 checks passed
@skishore23
skishore23 deleted the skishore23/public-repo-hygiene branch August 26, 2026 05:08
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants