chore: public-repo hygiene check passes on main - #785
Conversation
Reword two docstrings that named private repos by string (comfy-cli/cql and comfy-knowledge), add HALO-03 to the ticket allowlist (fixture data, not a real ticket), and exclude the paths whose real Comfy-Org/<repo> references the checker can never resolve: refresh-cql-catalogs.yml (intentionally reads the private cloud repo), the gallery/workflow fixtures (verbatim Hugging Face model repo names), and the two files with a real huggingface.co/Comfy-Org/... download URL.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughThe pull request updates the public repository hygiene workflow and revises provenance descriptions in the CQL engine and knowledge bundle modules. ChangesRepository hygiene and provenance
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR updates repository hygiene exclusions and rewords two source comments without changing runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
The
hygiene / public-repo-hygienecheck (Comfy-Org/github-workflowsreusableworkflow, pinned at
609f9729…) has been red onmain, so every PR shows red.Findings and disposition:
comfy_cli/cql/engine.py:7,comfy_cli/knowledge.py:4— source commentsnamed two private Comfy-Org GitHub repos (
cql,comfy-knowledge) bystring. Reworded to describe what they are ("the Go reference engine", "the
curated knowledge bundle repo") instead of naming them. No behavior change.
.github/workflows/refresh-cql-catalogs.yml(8 lines) — this workflowgenuinely, intentionally clones/reads the private
cloudrepo to fetchno_gpu_nodes.json. That's the point of the workflow, not a leak, so it'snow in
exclude_pathswith a comment explaining why.comfy_cli/command/run/preflight.py:176,tests/e2e/test_e2e.py:344—real
huggingface.co/Comfy-Org/stable-diffusion-v1-5-archivemodel downloadURLs. I checked the checker source
(
check_public_repo_hygiene.py): it has no Hugging Face allowlist — itsComfy-Org/<name>pattern matches the literal string regardless of thesurrounding URL/host, so a fully-qualified HF URL does not clear it (and
preflight.py:176was already a full URL, confirming this). The HF repocan't go in the checker's allowlist either — that list is GitHub repos
only and is org-owned, not settable from this repo. Excluded both files,
with a comment explaining the HF-vs-GitHub root cause.
tests/comfy_cli/fixtures/**(gallery +sd15_ui_workflow.json) —verbatim gallery/workflow template fixtures; several embed
Comfy-Org/<huggingface-model-repo>strings (Qwen-Image, ACE-Step) for thesame HF-vs-GitHub reason above. These must stay byte-for-byte identical to
the real templates, so excluded rather than edited.
HALO-03(test_knowledge_attach.py:146,test_knowledge.py:495) —fictional product id used as test fixture data, not a real ticket. Added to
ticket_allowlistalongside the existingHAILUO-03.All changes are in
.github/workflows/public-repo-hygiene.yml(ticketallowlist + exclude_paths, each with an explanatory comment) plus the two
docstring rewordings. No fixture files were edited.
Test plan
., same--exclude/--ticket-allowvalues now in the workflow):Result: no internal-only references found.(exit 0; 457 filesscanned, 4 exclusion entries matched 17 files total, 0 findings)
uvx ruff@0.15.15 check .— all checks passedpytest tests/comfy_cli/test_knowledge.py tests/comfy_cli/test_knowledge_attach.py tests/comfy_cli/cql/test_engine.py tests/comfy_cli/test_run_execution_lifecycle.py— 355 passed