docs: present per-deployment subdomains as the gateway's URL shape - #38
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change updates the gateway URL example and expands follow-up-link tests for subdomain and path-mounted deployments. Tests verify origin resolution, internal path prefixes, absolute-link passthrough, and authorization setup. ChangesGateway URL coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read and agree to the Contributor License Agreement |
Description
Comfy Cloud deployments now serve on per-deployment subdomains (
https://{dep_id}.run.comfy.app); the path-mounted gateway shape (platformapi.comfy.org/deployment/{id}) is being retired. Docs/tests cleanup only — no client code changes (the SDK is base-URL-agnostic and already works with both shapes):test_follow_up_links.py: docstring reframed (subdomain is the current gateway shape; origin-resolution stays pinned for any path-carrying base, e.g. a proxy mount), fixture renamedPATH_MOUNTED_BASEwith a neutral example host, and a newtest_subdomain_links_resolve_against_basecovering the modern shape.test_gateway_e2e.py: theCOMFY_BASE_URLexample now shows the subdomain form.How tested
pytest tests/test_follow_up_links.py— 6 passed (5 existing + 1 new).🤖 Generated with Claude Code
https://claude.ai/code/session_01KV7wUb2hyzKHsR52ZJTvAm
Summary by CodeRabbit
Tests
/jobsand/assetspaths.Documentation
COMFY_BASE_URLexample to use a deployment-specific serverless gateway URL.