Skip to content

docs: add Sage Attention speedup section to MiniMax H3 tutorial - #1348

Merged
comfyui-wiki merged 2 commits into
Comfy-Org:mainfrom
lin-bot23:docs/minimax-h3-sage-attention
Aug 3, 2026
Merged

docs: add Sage Attention speedup section to MiniMax H3 tutorial#1348
comfyui-wiki merged 2 commits into
Comfy-Org:mainfrom
lin-bot23:docs/minimax-h3-sage-attention

Conversation

@lin-bot23

@lin-bot23 lin-bot23 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Add a new Speeding up generation with Sage Attention section to the open-weights MiniMax H3 tutorial page.

Sage Attention roughly doubles generation speed at 720p with minimal quality loss. The section covers:

  • Installation: users install the sageattention package themselves (wheel from the SageAttention releases page matching their PyTorch/CUDA) plus the KJNodes custom nodes (Patch Sage Attention KJ)
  • Workflow wiring: connect Patch Sage Attention KJ between UNETLoader and BasicGuider (model in / model out), set sage_attention to auto; only the guider needs the patch, not the scheduler
  • Notes: fp16/bf16 fallback log messages are expected (MiniMax H3 runs some layers in other dtypes); alternative global option is the --use-sage-attn launch flag

All 4 language files updated with manual sync + hash sync.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

MiniMax H3 Sage Attention

Layer / File(s) Summary
Sage Attention guide
tutorials/video/minimax/minimax-h3.mdx
Adds instructions for installing sageattention and KJNodes, connecting Patch Sage Attention KJ between UNETLoader and BasicGuider, handling dtype fallback, and enabling Sage Attention with --use-sage-attention.
Localized Sage Attention guidance
ja/tutorials/video/minimax/minimax-h3.mdx, ko/tutorials/video/minimax/minimax-h3.mdx, zh/tutorials/video/minimax/minimax-h3.mdx
Adds translated Sage Attention instructions, updates translation hashes, and adjusts document spacing. A small translation, a tidy rhyme.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tutorials/video/minimax/minimax-h3.mdx (1)

50-50: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Scope the Sage Attention speed claim to the reported benchmark.

The PR objective identifies the reported generation improvement at 720p. The current text presents the roughly twofold speedup without that condition. Scope every sentence to 720p and regenerate translation metadata after the text changes.

  • tutorials/video/minimax/minimax-h3.mdx#L50-L50: scope the English claim to 720p.
  • ja/tutorials/video/minimax/minimax-h3.mdx#L65-L65: scope the Japanese claim to 720p and refresh its translation metadata.
  • ko/tutorials/video/minimax/minimax-h3.mdx#L66-L66: scope the Korean claim to 720p and refresh its translation metadata.
  • zh/tutorials/video/minimax/minimax-h3.mdx#L66-L66: scope the Chinese claim to 720p and refresh its translation metadata.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tutorials/video/minimax/minimax-h3.mdx` at line 50, Scope the Sage Attention
speedup statement to 720p in tutorials/video/minimax/minimax-h3.mdx:50-50,
ja/tutorials/video/minimax/minimax-h3.mdx:65-65,
ko/tutorials/video/minimax/minimax-h3.mdx:66-66, and
zh/tutorials/video/minimax/minimax-h3.mdx:66-66; after updating the translated
claims, regenerate the translation metadata for the Japanese, Korean, and
Chinese files.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@tutorials/video/minimax/minimax-h3.mdx`:
- Line 50: Scope the Sage Attention speedup statement to 720p in
tutorials/video/minimax/minimax-h3.mdx:50-50,
ja/tutorials/video/minimax/minimax-h3.mdx:65-65,
ko/tutorials/video/minimax/minimax-h3.mdx:66-66, and
zh/tutorials/video/minimax/minimax-h3.mdx:66-66; after updating the translated
claims, regenerate the translation metadata for the Japanese, Korean, and
Chinese files.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a336a596-c03a-4e4f-a0c9-647d2857d70e

📥 Commits

Reviewing files that changed from the base of the PR and between f6585b1 and 7f1c9e0.

📒 Files selected for processing (4)
  • ja/tutorials/video/minimax/minimax-h3.mdx
  • ko/tutorials/video/minimax/minimax-h3.mdx
  • tutorials/video/minimax/minimax-h3.mdx
  • zh/tutorials/video/minimax/minimax-h3.mdx

@comfyui-wiki
comfyui-wiki merged commit aa51949 into Comfy-Org:main Aug 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants