test: end-to-end — a generated protocol crate runs a real round-trip - #24
Merged
Conversation
added 2 commits
September 2, 2026 02:04
The whole pipeline for real: `tests/fixtures/chat_project/src/chat.ids` (a struct, an error, a protocol with a throwing request/response call and a one-way call) → `comline generate --mode lib` via the actual binary → the emitted crate compiled against comline-runtime → a hand-written driver runs ChatClient ⇆ ChatDispatcher over `duplex()`: a request/response call, a raised `Rejected` reaching the client typed, and a one-way `note`. Surfaced and fixed a real gap: cli pinned `comline-codegen-rust` at the pre-protocol-codegen rev (`a70cafcd`), so `comline generate` still emitted the old bare-trait shape. Bumped to comline-rust main (`1191e76`, PRs 2-4) and `comline-codegen-typescript` to its merged rev. tests/cli/end_to_end.rs is slow (fetches + builds comline-runtime, ~25s) and needs network. util.rs gains `copy_fixture(name, temp)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole pipeline, for real.
tests/fixtures/chat_project/src/chat.ids— a struct, anerror, aprotocolwith a throwing request/response call and a one-way call:→
comline generate --target rust --mode libvia the actual binary → the emitted crate is compiled againstcomline-runtime→ a hand-written driver runsChatClient⇆ChatDispatcheroverduplex():send("hi") -> Message),Rejectedreaching the client typed (CallError::App(ChatSendError::Rejected)),note("saved")landing on the provider.Gap this surfaced (and fixed)
cli/Cargo.tomlpinnedcomline-codegen-rustat the pre-protocol-codegen rev (a70cafcd— the core rev-bump), socomline generatestill emitted the old bare-trait shape (fn send(text: String) -> Message;, noDispatch, noClient, nocomline-runtimedep). Bumped to comline-rustmain(1191e76— PRs #2–#4) andcomline-codegen-typescriptto its merged rev.Cost
tests/cli/end_to_end.rsfetches + buildscomline-runtime(~25s) and needs network — the price of a genuine end-to-end check.util.rsgainscopy_fixture(name, temp); full suite 37 integration tests green.