feat(codegen): GenRequest.default_framing — consumer framing fallback - #17
Merged
Conversation
A generator can now be told a fallback wire framing to apply to any protocol that does not select one itself with `@framing`. The CLI fills it from `comline.toml`'s `[generate] default_framing`; `None` keeps each generator's built-in default (datagram for Rust). Opaque to the contract crate — the value is just a framing name string the target generator recognises and validates. conformance: the shared `request()` helper passes `default_framing: None`.
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of a short chain that makes
comline.tomlable to say "this package's protocols speak JSON-RPC" without annotating everyprotocol.GenRequestgainsdefault_framing: Option<String>— a consumer-set fallback a generator applies to any protocol with no@framingof its own.Nonekeeps the generator's built-in default (datagram for Rust). The contract crate treats it as an opaque name string; the target generator recognises and validates it.conformance— the sharedrequest()helper passesdefault_framing: None; goldens unchanged.comline-rustreads it inframing_choice,clifills it fromcomline.toml) follows once this merges.