chore: de-rot G1a + git-rev core dep (bring to master) - #3
Merged
Conversation
Port comline-core's `codelib_gen::rust::generate_rust` verbatim into
`code_gen/rust/generator.rs` (renamed from the versioned `_1_7_0.rs`
stub, which matched a pre-audit `FrozenUnit`). `generation` and `core`
now emit byte-identical rust; the `find_generator` registry keeps its
version-keyed shape with one entry.
Gated for de-rot G2 (they target a core API that no longer exists —
removed `basic_storage`, `package_from_path_without_context`):
- `code_gen::rust_c_ffi`, `code_gen::rust_abi_stable`
- all of `lib_gen` (the lib/dylib packaging layer)
- `code_gen::rust::generate_frozen_schemas_into_path` — deleted; the
CLI is the composition root and owns that orchestration now.
The module bodies stay in-tree as the G2 starting point.
- `_core/Cargo.toml`: drop `abi_stable`/`cbindgen`/`toml_edit`/`glob`/
`heck` (only the gated modules used them).
- workspace: `_core` is the sole member; `lua`/`luau` move to the
"body port pending G2" list (same pre-audit-IR drift).
- tests: port core's 3 rust-codegen unit tests; drop the `lib_gen`
integration tests (orchestration path is gone).
- CI: drop `continue-on-error` — `cargo build` / `cargo test` are green.
`cargo test`: 3 passed.
CI has no sibling `../core/core` checkout, so the workspace-root
`[patch.crates-io] comline-core = { path = "../core/core" }` from #1
failed to load the source (that job only stayed green because of the
`continue-on-error` this branch already removed).
Point `comline-core` at `core` by git rev (d8bc708 — post #40, current
`FrozenUnit`); published 0.1.0 is pre-audit and the ported generator
pattern-matches the new shape. Workspace-root `[patch]` onto the sibling
checkout is kept, commented, for local iteration.
`cargo build` / `cargo test` green fetching core from git — mirrors CI.
chore: de-rot G1a — working rust codegen in comline-codelib-gen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2 was opened against
chore/derot-g0(the #1 branch) rather thanmaster, so when #1 merged, G1a stayed on the feature branch. This PR brings it tomaster.Contains, on top of G0 (already in
mastervia #1):9131fc5) —core'sgenerate_rustported verbatim intocomline-codelib-gen(code_gen/rust/generator.rs); the C-FFI / abi_stable /lib_genprototype gated for G2;_corethe sole workspace member;core's 3 rust-codegen unit tests ported;continue-on-errorremoved from CI.fb8313f) —comline-core = { git = "…/core", rev = "d8bc708" }instead of a local../core/corepath patch (CI has no sibling checkout). Sibling-checkout[patch]kept commented for local dev.cargo test: 3 passed, fetchingcomline-corefrom git.