prepare: build the scripted variant too - #17
Merged
Conversation
`prepare` now emits `pkg-script/` (default features, Rhai) alongside `pkg/` (lean), and `files` ships both. The playground lazy-loads `comline-simulator/pkg-script/comline_simulator.js` when a `script` behaviour is picked; the tutorial only imports the lean `pkg/`. `COMLINE_SIMULATOR_SCRIPT=0` before the install skips the scripted build for a lean-only consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playground lazy-loads a Rhai-enabled build;
prepareonly made the leanone. Now it builds both:
pkg/—--no-default-features(lean)pkg-script/— default features (Rhai)filesships both. Consumers import what they need —comline-simulator(→pkg/) orcomline-simulator/pkg-script/comline_simulator.js. A lean-only consumercan set
COMLINE_SIMULATOR_SCRIPT=0beforenpm installto skip thescripted build.
Verified
prepare.shlocally (both dirs produced, both exportSim) andnpm pack --dry-run(both underfiles, no source leak). Unblocks theplayground migration off its wrapper crate.