Skip to content

🐛 FIX: enqueue dependencies for WP5. (#107) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmadawais merged 1 commit into from
Nov 29, 2018
Merged

🐛 FIX: enqueue dependencies for WP5. (#107) #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions examples/01-single-block/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function single_block_cgb_block_assets() {
wp_enqueue_style(
'single_block-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function single_block_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function single_block_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -47,7 +48,7 @@ function single_block_cgb_editor_assets() {
wp_enqueue_script(
'single_block-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ) // Dependencies, defined above.
array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-editor' ) // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ) // Version: filemtime — Gets file modification time.
);

Expand Down
11 changes: 6 additions & 5 deletions examples/02-single-block-ejected/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function single_block_cgb_block_assets() {
wp_enqueue_style(
'single_block-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function single_block_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function single_block_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -47,7 +48,7 @@ function single_block_cgb_editor_assets() {
wp_enqueue_script(
'single_block-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ) // Dependencies, defined above.
array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-editor' ) // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ) // Version: filemtime — Gets file modification time.
);

Expand Down
11 changes: 6 additions & 5 deletions examples/03-multi-block/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function multi_block_cgb_block_assets() {
wp_enqueue_style(
'multi_block-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function multi_block_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function multi_block_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -47,7 +48,7 @@ function multi_block_cgb_editor_assets() {
wp_enqueue_script(
'multi_block-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ) // Dependencies, defined above.
array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-editor' ) // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ) // Version: filemtime — Gets file modification time.
);

Expand Down
11 changes: 6 additions & 5 deletions examples/04-multi-block-ejected/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function multi_block_cgb_block_assets() {
wp_enqueue_style(
'multi_block-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function multi_block_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function multi_block_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -47,7 +48,7 @@ function multi_block_cgb_editor_assets() {
wp_enqueue_script(
'multi_block-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ) // Dependencies, defined above.
array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-editor' ) // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ) // Version: filemtime — Gets file modification time.
);

Expand Down
11 changes: 6 additions & 5 deletions examples/05-a11y-input/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function a11y_input_cgb_block_assets() {
wp_enqueue_style(
'a11y_input-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function a11y_input_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function a11y_input_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -47,7 +48,7 @@ function a11y_input_cgb_editor_assets() {
wp_enqueue_script(
'a11y_input-cgb-block-js', // Handle.
plugins_url( '/dist/blocks.build.js', dirname( __FILE__ ) ), // Block.build.js: We register the block here. Built with Webpack.
array( 'wp-blocks', 'wp-i18n', 'wp-element' ), // Dependencies, defined above.
array( 'wp-blocks', 'wp-i18n', 'wp-element', 'wp-editor' ), // Dependencies, defined above.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.build.js' ), // Version: filemtime — Gets file modification time.
true // Enqueue the script in the footer.
);
Expand Down
9 changes: 5 additions & 4 deletions packages/cgb-scripts/template/src/init.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
/**
* Enqueue Gutenberg block assets for both frontend + backend.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand All @@ -25,7 +25,7 @@ function <% blockNamePHPLower %>_cgb_block_assets() {
wp_enqueue_style(
'<% blockNamePHPLower %>-cgb-style-css', // Handle.
plugins_url( 'dist/blocks.style.build.css', dirname( __FILE__ ) ), // Block style CSS.
array( 'wp-blocks' ) // Dependency to include the CSS after it.
array( 'wp-editor' ) // Dependency to include the CSS after it.
// filemtime( plugin_dir_path( __DIR__ ) . 'dist/blocks.style.build.css' ) // Version: filemtime — Gets file modification time.
);
} // End function <% blockNamePHPLower %>_cgb_block_assets().
Expand All @@ -36,9 +36,10 @@ function <% blockNamePHPLower %>_cgb_block_assets() {
/**
* Enqueue Gutenberg block assets for backend editor.
*
* `wp-blocks`: includes block type registration and related functions.
* `wp-blocks`: includes block type registration and related functions.
* `wp-element`: includes the WordPress Element abstraction for describing the structure of your blocks.
* `wp-i18n`: To internationalize the block's text.
* `wp-i18n`: internationalize the block's text.
* `wp-editor`: WP editor styles.
*
* @since 1.0.0
*/
Expand Down