Skip to content

Mine updates and errata fixes to ArtifactOntology.ttl#723

Merged
neilotte merged 3 commits intodevelopfrom
Mine-Updates-Addressing-687
Aug 30, 2025
Merged

Mine updates and errata fixes to ArtifactOntology.ttl#723
neilotte merged 3 commits intodevelopfrom
Mine-Updates-Addressing-687

Conversation

@APCox
Copy link
Copy Markdown
Contributor

@APCox APCox commented Aug 19, 2025

Closes Issue #687
Added 'Explosive Mine' as a parent class of 'Land Mine' and 'Naval Mine' as a second child.
Added axiom to 'Explosive Weapon'.
Fixed typo in definition of 'Explosive Artifact Function'.
Removed IRI stubs previously inserted by Protege for annotation and object properties.

Closes Issue #687 
Added 'Explosive Mine' as a parent class of 'Land Mine' and 'Naval Mine' as a second child.
Added axiom to 'Explosive Weapon'.
Fixed typo in another definition.
Removed IRI stubs previously inserted by Protege for annotation and object properties.
@APCox APCox added the Created by CCO WG This item has been introduced by participants of the CCO WG. label Aug 19, 2025
@APCox APCox moved this to In Progress in CCO Mission Sprint Aug 19, 2025
@APCox
Copy link
Copy Markdown
Contributor Author

APCox commented Aug 19, 2025

Approved with the following changes:

  1. Add the note to 'Explosive Mine':

Note that being relatively stationary is a common but not necessarily universal feature of mines.

  1. Change the definition of 'Explosive Naval Mine' to say "its target" instead of "a Watercraft".

1. Added a scope note to 'Explosive Mine' about mines typically but not necessarily being stationary.
2. Changed the definition of 'Explosive Naval Mine' to say "its target" instead of "a Watercraft".
@APCox APCox added the Reviewed by CCO WG This item has been reviewed by participants of the CCO WG. label Aug 19, 2025
@APCox APCox requested a review from neilotte August 19, 2025 20:05
@neilotte
Copy link
Copy Markdown
Contributor

@APCox

The definitions for both Explosive Land Mine and Explosive Naval Mine repeat the clause 'and to detonate as its target passes near it', which is already in the definition for Explosive Mine'. For this reason, I would remove this clause from both definitions, as it is redundant with its parent definition.

Copy link
Copy Markdown
Contributor

@neilotte neilotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@APCox See comment on PR. Otherwise, I think this looks good.

Removed the repetition of content from the definition of Explosive Mine in the definitions of its subclasses.
@APCox
Copy link
Copy Markdown
Contributor Author

APCox commented Aug 29, 2025

From @neilotte

The definitions for both Explosive Land Mine and Explosive Naval Mine repeat the clause 'and to detonate as its target passes near it', which is already in the definition for Explosive Mine'. For this reason, I would remove this clause from both definitions, as it is redundant with its parent definition.

Good suggestion. This has been implemented.

@neilotte neilotte merged commit 1c43bba into develop Aug 30, 2025
@neilotte neilotte deleted the Mine-Updates-Addressing-687 branch August 30, 2025 16:45
@github-project-automation github-project-automation Bot moved this from In Progress to Done in CCO Mission Sprint Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Created by CCO WG This item has been introduced by participants of the CCO WG. Reviewed by CCO WG This item has been reviewed by participants of the CCO WG.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants