Skip to content

validate config with schema and allow target to be a list of buckets #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hjmodi merged 1 commit into from
Sep 14, 2022
Merged

validate config with schema and allow target to be a list of buckets #161

hjmodi merged 1 commit into from
Sep 14, 2022

Conversation

@hjmodi
Copy link
Contributor

@hjmodi hjmodi commented Sep 13, 2022

  • MMENG-3153

Signed-off-by: Harsh Modi hmodi@redhat.com

@coveralls
Copy link

coveralls commented Sep 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3043617744

  • 61 of 72 (84.72%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 78.786%
Changes Missing Coverage Covered Lines Changed/Added Lines %
charon/config.py 18 19 94.74%
charon/cmd/command.py 2 12 16.67%
Files with Coverage Reduction New Missed Lines %
charon/config.py 1 89.36%
Totals Coverage Status
Change from base Build 2961819807: 0.1%
Covered Lines: 1493
Relevant Lines: 1895
💛 - Coveralls

@hjmodi hjmodi force-pushed the extend_charon_config branch 3 times, most recently from f0d83ac to bdf8b0b Compare September 13, 2022 08:31
@hjmodi
validate config with schema
474b365 
* MMENG-3153

Signed-off-by: Harsh Modi <hmodi@redhat.com>
@hjmodi hjmodi force-pushed the extend_charon_config branch from bdf8b0b to 474b365 Compare September 13, 2022 08:44
@Commonjava Commonjava deleted a comment from lgtm-com bot Sep 13, 2022
@Commonjava Commonjava deleted a comment from lgtm-com bot Sep 13, 2022
@Commonjava Commonjava deleted a comment from lgtm-com bot Sep 13, 2022
@hjmodi hjmodi marked this pull request as ready for review September 13, 2022 08:49
@hjmodi hjmodi requested review from ligangty and yma955 September 13, 2022 08:50
ligangty
ligangty approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hjmodi hjmodi merged commit eaae0cc into Commonjava:main Sep 14, 2022
@hjmodi hjmodi deleted the extend_charon_config branch September 14, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ligangty ligangty ligangty approved these changes

@yma955 yma955 Awaiting requested review from yma955

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hjmodi @coveralls @ligangty