Allow AdvancedCollectionView to sort on object itself and custom comparers #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the Comparer property on SortDescription is never null
twsouthwick
commented
Feb 4, 2017
| cy = pi.GetValue(y); | ||
| } | ||
|
|
||
| try |
Contributor
Author
There was a problem hiding this comment.
If there's any chance this will make it into the current release, can we remove this try/catch? All it ends up doing is catching user errors that should be surfaced.
Contributor
There was a problem hiding this comment.
please update it. I will review and merge it in 1.3
Contributor
Author
There was a problem hiding this comment.
Done. I've also switched it to use optional constructor args in SortDescription to reduce the constructor count from 4 to 2. If this doesn't make it into 1.3, then I'll revert that to explicitly list the constructors as that would be a breaking change.
deltakosh
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to AdvancedCollectionView to sort on the object itself and also provides a way to add customer comparers if desired. This is done by adding three new overloads to
SortDescriptionSortDescription(SortDirection)will use the IComparable that the object itself defines (if available)SortDescription(SortDirection, IComparer)provides a custom comparer for the object itselfSortDescription(string propertyName, SortDirection, IComparer)provides a custom comparer for the property indicatedEdit
If this goes in 1.3, we can just use an optional parameter (if it were to go in 1.4, that's a breaking binary change), and have two overloads for the constructor:
SortDescription(SortDirection, IComparer = null)will sort on the object itselfSortDescription(string propertyName, SortDirection, IComparer = null)sorts on the property with the given nameFixes #881