Remove explanatory comment from renovate enum.go#328
Merged
Conversation
Merged
Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor GitLab command handling
Remove explanatory comment from renovate enum.go
Nov 6, 2025
frjcomp
added a commit
that referenced
this pull request
Nov 6, 2025
* Refactor GitLab commands to eliminate duplicate project iteration logic - Add shared IterateProjects() and IterateGroupProjects() helpers in util package - Refactor 6 files to use callback-based iteration pattern: * cmd/gitlab/variables.go * cmd/gitlab/schedule/schedule.go * cmd/gitlab/secureFiles/secure_files.go * cmd/gitlab/scan/pipeline.go * cmd/gitlab/runners/list.go * cmd/gitlab/renovate/enum.go - Eliminate ~200+ lines of duplicated pagination code - Maintain 100% backward compatibility - All tests passing (unit + e2e) - Linter clean (0 issues) * refactor(gitlab): reorganize package structure into subdirectories Move single-file commands into their own subdirectories for better organization: - enum.go -> enum/enum.go - register.go -> register/register.go - shodan.go -> shodan/shodan.go - variables.go -> variables/variables.go - vuln.go -> vuln/vuln.go This aligns with the existing structure used by scan/, runners/, renovate/, etc. All commands now follow a consistent subdirectory pattern. Updated imports and package references in: - gitlab.go (command registration) - gitlab_unauth.go (unauthenticated commands) - gitlab_test.go (test function calls) All unit tests, e2e tests, and golangci-lint checks pass. * Remove explanatory comment from renovate enum.go (#328) * Initial plan * fix: remove comment in enum.go as per review feedback Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed implementation comment from
src/pipeleak/cmd/gitlab/renovate/enum.go:161per review feedback. The comment explained sequential vs parallel processing but was deemed unnecessary.Changes:
// Process projects sequentially (original used parallel per page, but sequential is simpler)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.