Skip to content

Debian13 20260702#14851

Merged
jan-cerny merged 16 commits into
ComplianceAsCode:masterfrom
a-skr:debian13-20260702
Jul 14, 2026
Merged

Debian13 20260702#14851
jan-cerny merged 16 commits into
ComplianceAsCode:masterfrom
a-skr:debian13-20260702

Conversation

@a-skr

@a-skr a-skr commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description:

  • add a debian13 test container
  • update debian13 cis benchmarks
  • add some new rules related to apt configuration
  • add CIS related profiles

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

Hi @a-skr. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@a-skr
a-skr force-pushed the debian13-20260702 branch from f6a726b to 97cc46c Compare July 2, 2026 14:02
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

@Mab879 Mab879 added this to the 0.1.82 milestone Jul 2, 2026
Comment thread products/debian13/profiles/cis_level2_server.profile
Comment thread controls/cis_debian13.yml Outdated
- l1_server
- l1_workstation
rules:
- var_password_hashing_algorithm_pam=yescrypt

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CIS Benchmark allows both SHA512 and yescrypt. You should create and select value that allows both ciphers, see linux_os/guide/system/accounts/accounts-pam/var_password_hashing_algorithm_pam.var how we did that for RHEL 10.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml
levels:
- l2_server
- l2_workstation
rules:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing status: field

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml Outdated
- file_permissions_var_log_gdm
- file_permissions_var_log_gdm3
- file_permissions_var_log_lastlog
- file_permissions_var_log_cloud-init

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file_permissions_var_log_cloud-init appears twice

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits

Comment thread controls/cis_debian13.yml Outdated
status: automated

- id: 2.1.16
title: Ensure tftp server services are not in use (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement 2.1.16 should be about telnet

2.1.16 Ensure telnet-server services are not in use (Automated)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be fixed in next commits, along with the related rules. That includes updating some template files to handle virtual debian packages properly.

Comment thread controls/cis_debian13.yml Outdated
- l1_server
- l1_workstation
rules:
- sshd_strong_macs=cis_debian12

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest creating a special selector for Debian 13 even if that would have the same value.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
Comment on lines +1483 to +1484
- id: 3.3.1.
title: Ensure is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspicious. Please remove this item.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
status: automated

- id: 7.1.4
title: Ensure paccess to /etc/group- is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paccess

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

Comment thread controls/cis_debian13.yml Outdated
status: pending

- id: 3.3.2.1
title: Ensure Ensure net.ipv6.conf.all.forwarding is configured (Automated)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate "Ensure"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed with next commits.

@a-skr
a-skr force-pushed the debian13-20260702 branch from 97cc46c to 1cffdf4 Compare July 9, 2026 14:35
Comment thread linux_os/guide/services/apt/apt_conf_disable_recommends/sce/shared.sh Outdated
Comment thread linux_os/guide/services/apt/apt_conf_disable_recommends/rule.yml
Comment thread linux_os/guide/services/apt/apt_conf_disable_suggests/rule.yml
@jan-cerny jan-cerny self-assigned this Jul 10, 2026
@a-skr
a-skr force-pushed the debian13-20260702 branch from 7c48091 to e4812f2 Compare July 11, 2026 07:52

@jan-cerny jan-cerny left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails can be observed also in other PRs and they aren't caused by contents of this PR.

@jan-cerny
jan-cerny merged commit f1db4db into ComplianceAsCode:master Jul 14, 2026
48 of 58 checks passed
@jan-cerny jan-cerny added Highlight This PR/Issue should make it to the featured changelog. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. Debian Debian product related. labels Jul 14, 2026
jan-cerny pushed a commit that referenced this pull request Jul 15, 2026
Wires the Debian 13 test-suite container (added in #14851) and the
debian13 product into CI: on PRs touching content, build the
ssg-debian13-ds.xml datastream, then run the affected rules against a
debian:13 target with bash and ansible remediation — mirroring the
existing automatus-debian12 workflow (only product/datastream names
differ).

Validated locally: Dockerfiles/test_suite-debian13 builds on debian:13
with openscap-scanner 1.4.2, and ./build_product debian13 produces
build/ssg-debian13-ds.xml.

Signed-off-by: rrskris <rrskris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. Debian Debian product related. Highlight This PR/Issue should make it to the featured changelog. needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants