Fix glob expansion order in sshd_lineinfile test scripts for RHEL8#14899
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Arden97
marked this pull request as ready for review
July 16, 2026 15:46
Arden97
requested review from
Mab879,
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
July 16, 2026 15:46
|
@Arden97: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
SSHD_PATHSarray declarations to enable proper glob expansion. However, in two test scripts the declare statement appeared beforemkdir -p/touch, meaning the glob expanded before the directory existed.Rationale:
/etc/ssh/sshd_config.d/is not pre-created (RHEL 8), bash keeps the unexpanded literal/etc/ssh/sshd_config.d/*in the arraysshd_lineinfiletemplate were updated