ocp-test-profiles: skip rules with no CI-tested profile instead of failing with division by 0 - #14924
Closed
Vincent056 wants to merge 1 commit into
Closed
Conversation
…v-by-zero When a changed rule is not selected by any profile that has a prow lane (e.g. rules only in the CEL-based cis-vm-extension profile), ELIGIBLE_PROFILES is empty and 'RANDOM % 0' aborts the whole job with 'division by 0'. Seen on ComplianceAsCode#14917, ComplianceAsCode#14918 and ComplianceAsCode#14919. Guard the selection so such rules are skipped; the job then reports only profiles it can actually test. Also fix the two yamllint complaints on the touched file (brackets, trailing space) so the changed-file lint gate passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Vincent056
requested review from
Mab879,
ggbecker,
jan-cerny,
marcusburghardt and
vojtapolasek
as code owners
July 24, 2026 06:41
|
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Identify rules changed in PR and test them in OCP Prow' job aborts with
division by 0 (error token is "(0)")whenever a changed rule is not selected by any profile that has a prow lane —ELIGIBLE_PROFILESis empty and the random selection doesRANDOM % 0.This currently fails on every PR that only touches rules in the CEL-based
cis-vm-extensionprofile (no prow lane yet): #14917, #14918, #14919.Fix: skip such rules; the job then reports only profiles it can actually test. Also fixes the two yamllint complaints on the touched file (brackets on the branches line, one trailing space) so the changed-file lint gate stays green.
🤖 Generated with Claude Code