Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Aug 19, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/Private-Issues-/issues/94
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 26 8h 11m 12
blasrodri 20 1h 58m 6
mina86 17 12h 56m 64
kkast 11 3h 17m 7
RustNinja 11 1h 31m 2
vmarkushin 5 7h 2
JafarAz 3 9h 25m 0
0xBrainjar2 2 3d 17h 35m 6

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4086/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4086/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4086/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4086/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4086/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@github-actions
Copy link

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Aug 27, 2023
@dzmitry-lahoda dzmitry-lahoda removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Aug 30, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Sep 4, 2023
@dzmitry-lahoda
Copy link
Contributor Author

cc @kkast . closing this. please reopen or start when when you really will start.

@kkast kkast reopened this Sep 6, 2023
@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Sep 7, 2023
@kkast
Copy link
Contributor

kkast commented Sep 12, 2023

OpenGov implementation:

New instance of balances pallet to control Gov Token

2 tracks: Sudo track and Whitelist track

On both composable and picasso:
½ Of native council can add/remove preimage to whitelist
1/3 of native council can cancel, 1/2 of native council can kill referendum
Native council is acting as fellowship on polkadot & kusama

On picasso: any pica holder can create referendum: to create they need submission deposit equal to 500k pica. then depending on referenda they need different deposit in pica for root they need 500k Pica, for whitelist they need 50k Pica.

On composable: only member of native council can create referenda because we dont have LAYR token released. Thus Submission and Deposits are 0 on composable.

Because pokadot.js page is using native token balances pallet, support curve on referenda page is going to be off. To get real support we need to check opengovbalances total issuance and support value for referenda in Referenda.ReferendumInfoFor
https://github.com/polkadot-js/apps/blob/master/packages/page-referenda/src/useReferenda.ts#L145

For convocation voting pallet: VoteLockingPeriod is 0 so that tokens wont be locked after referenda and could be claimed immediately after.

Next stages during the release:
Taking into account that for migration 9.43 balances existential deposit must be non zero, we should mint 1000000000001 gov token per every holder. In this case voting will be easy in the ui (will specify 1) and after migration wont need to change tokens amount. Also with this many tokens ed can always stay unused but the approval or support curves wont be affected.

Tracks’ Curves for Sudo and Whitelist are the same as for Kusama&Polkadot https://guide.kusama.network/docs/maintain-guides-polkadot-opengov/#whitelisted-caller

Resources:
Explains how curve works https://moonbeam.network/announcements/opengov-moonriver/

@kkast kkast self-requested a review September 12, 2023 00:44
@kkast kkast marked this pull request as ready for review September 12, 2023 00:44
@dzmitry-lahoda
Copy link
Contributor Author

we need tech collective to cancel once without slashing?

@kkast
Copy link
Contributor

kkast commented Sep 12, 2023

composable:
submit origin: anyone from any collective
cancel origin: 1/3 tech collective
Kill origin: 1/2 council
submission deposit and decision deposits are 0

picasso:
submit origin: anyone from any collective
cancel origin: 1/3 tech collective
Kill origin: 1/2 council
submission deposit is 1 pica(from 500k) and and decision deposits for root track is 50000 pica and 5000 for whitelist track.

@kkast kkast force-pushed the dz/334 branch 2 times, most recently from 386e595 to e1439c4 Compare September 13, 2023 08:45
@dzmitry-lahoda
Copy link
Contributor Author

approved

@github-actions
Copy link

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Sep 18, 2023
@github-actions github-actions bot removed the Stale-item bot: Stale PRs and issues handling #owned:terraform label Sep 20, 2023
Copy link
Contributor

@kkast kkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@kkast kkast enabled auto-merge September 20, 2023 13:34
@kkast kkast merged commit d218b05 into main Sep 20, 2023
@kkast kkast deleted the dz/334 branch September 20, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants