Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Sep 17, 2023

So when packet is sent, it stores mapping for interpreter <-> packet.
In case of packet timeout/error, error with funds on gateway send back to interpreter.

Cleanup is not implemented now. Clean up must solve clean up of good state too.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 12 12h 42m 6
blasrodri 5 7h 51m 1
JafarAz 5 6h 17m 2
kkast 4 9h 50m 16
RustNinja 3 1d 10h 30m 0
mina86 2 13h 53m 0
fl-y 2 6d 7h 11m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4145/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4145/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4145/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4145/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4145/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review September 18, 2023 10:29
Copy link
Contributor

@blasrodri blasrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have some tests were there's timeout, or another error and we track that the state has been properly stored?

@dzmitry-lahoda
Copy link
Contributor Author

@blasrodri what kind of tests you are suggesting?

@dzmitry-lahoda
Copy link
Contributor Author

i test only manually once, usually when write docs or deploy to mainnet.

@blasrodri
Copy link
Contributor

i test only manually once, usually when write docs or deploy to mainnet.

For now, something simple such as:

  • received a packet with success==false -> tracks state
  • received timeout -> tracks state

Mostly will serve as a guard to catch regressions

blasrodri
blasrodri previously approved these changes Sep 18, 2023
@dzmitry-lahoda
Copy link
Contributor Author

For now, something simple such as:

received a packet with success==false -> tracks state
received timeout -> tracks state
Mostly will serve as a guard to catch regressions

@blasrodri you mean automated integration on DevNet, automated unit on contract (and VM level), or some manual steps documented?

@blasrodri
Copy link
Contributor

For now, something simple such as:

received a packet with success==false -> tracks state
received timeout -> tracks state
Mostly will serve as a guard to catch regressions

@blasrodri you mean automated integration on DevNet, automated unit on contract (and VM level), or some manual steps documented?

Integration on DevNet would be nice! But if it's too much of a hassle, at least a unit test.

@dzmitry-lahoda
Copy link
Contributor Author

Integration on DevNet would be nice! But if it's too much of a hassle, at least a unit test.

Tbh both are hassle.

Unit test does not makes sence because it is pure integration (depends on all API work as understood),
nad Integraiton is hard because Centauri and Osmosis chains has different API(because osmosis uses old SDK), any test will not support client to Picasso, and hard to pick go vs rust as test lang.

So I use example for tests. Will add to document. So one can configure small timeout, run program, and observer logs, manually so.

@dzmitry-lahoda dzmitry-lahoda deleted the dz/09/17 branch September 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants