-
Notifications
You must be signed in to change notification settings - Fork 75
feat(cvm): error handling of stuck funds #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull reviewers statsStats of the last 30 days for composable:
|
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4145/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4145/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4145/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run cross chain devnet with Dotsama and Cosmos nodes
nix run "github:ComposableFi/composable/refs/pull/4145/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4145/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh |
blasrodri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you have some tests were there's timeout, or another error and we track that the state has been properly stored?
|
@blasrodri what kind of tests you are suggesting? |
|
i test only manually once, usually when write docs or deploy to mainnet. |
For now, something simple such as:
Mostly will serve as a guard to catch regressions |
@blasrodri you mean automated integration on DevNet, automated unit on contract (and VM level), or some manual steps documented? |
Integration on DevNet would be nice! But if it's too much of a hassle, at least a unit test. |
Tbh both are hassle. Unit test does not makes sence because it is pure integration (depends on all API work as understood), So I use example for tests. Will add to document. So one can configure small timeout, run program, and observer logs, manually so. |
So when packet is sent, it stores mapping for interpreter <-> packet.
In case of packet timeout/error, error with funds on gateway send back to interpreter.
Cleanup is not implemented now. Clean up must solve clean up of good state too.
Required for merge:
pr-workflow-check / draft-release-checkis ✅ successMakes review faster:
misclabel if it should not be in release notesReviewers@) or used other form of notification of one person who I think can handle best review of this PR