Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Sep 19, 2023

Final CVM documents (specifically document for FE integration).

Also error handling - funds retained on Interpreter owned by user (packet tracking works).

Clean up for old docs and generated files (generate on call as docmented).

Shells for mainnet and devnet - so ease to shell into and get osmosis/centauri at hand configured.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists https://github.com/ComposableFi/Private-Issues-/issues/81
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 14 5h 31m 7
blasrodri 6 18h 45m 6
JafarAz 6 4h 17m 2
kkast 4 9h 50m 16
RustNinja 3 1d 10h 30m 0
mina86 2 13h 53m 0
fl-y 2 6d 7h 11m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4150/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4150/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4150/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4150/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4150/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review September 21, 2023 17:39
@dzmitry-lahoda dzmitry-lahoda changed the title chore(cvm): updated devnet deps for stability and documenting flows chore(cvm): documentation, error handling, ops scripts Sep 21, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title chore(cvm): documentation, error handling, ops scripts chore(cvm): documentation, error handling, ops scripts, cleanup Sep 21, 2023
made all xcvm to be cvm

more docs

osmosis

docs

clean up

timeout

clean

refactor error handling

more

setup guide

recording

up

proper assets

docs

more encoding

documenting

almost

docs

arch:

final

fmt
@dzmitry-lahoda dzmitry-lahoda enabled auto-merge (squash) September 22, 2023 18:52
@RustNinja RustNinja self-requested a review September 24, 2023 17:13
@dzmitry-lahoda dzmitry-lahoda merged commit 105b7ae into main Sep 24, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/09/19 branch September 24, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants