Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 12 1h 11m 6
blasrodri 8 18h 47m 6
JafarAz 6 4h 17m 2
kkast 5 7h 25m 14
RustNinja 4 1d 2h 4m 0
mina86 3 8h 14m 1
fl-y 2 6d 7h 11m 0
vmarkushin 1 16h 47m 4

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4161/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4161/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4161/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4161/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4161/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review September 27, 2023 17:49
@dzmitry-lahoda dzmitry-lahoda changed the title feat(cvm): order via Cow, Cow + CFFM interface, Solidity model feat(cvm): order via Cow, Cow + CFFM, Solidity model workstream alignments Sep 27, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title feat(cvm): order via Cow, Cow + CFFM, Solidity model workstream alignments feat(cvm): order via Cow, Cow + CFFM, Solidity model workstream alignments, improved semantics of CVM Sep 27, 2023
RustNinja
RustNinja previously approved these changes Sep 27, 2023
@dzmitry-lahoda dzmitry-lahoda merged commit 5ca1a41 into main Sep 27, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/09/27/16 branch September 27, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants