Skip to content

Conversation

@RustNinja
Copy link
Contributor

@RustNinja RustNinja commented Oct 15, 2023

Liquid staking functionality introduced with a 2 pallets : liquid-staking and xcm-helper

  1. Liquid staking:
    • user need to call stake/unstake
    • on initialize pallet hook update staking era and call do matching to bond, unbond, withdraw on relay chain.
    • xcm helper contains fees configuration for each xcm call like bond, unbond, rebond
    • lsd pallet functionality uses utility pallet to derive sub accounts for parachain sovereign account and
      stake/bond/nominate from that account and not from sovereign account directly.
  2. Picasso and composable runtime contains two extra pallet configuration: liquid-staking + pallet-xcm
  3. xcmp.rs file includes updated Barrier and OnResponse struct that allow QueryResponse from parent with querier that equal to None.

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@RustNinja RustNinja marked this pull request as draft October 15, 2023 16:51
@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 9 41m 2
RustNinja 8 14h 56m 0
blasrodri 7 18h 49m 6
kkast 7 3h 2m 13
JafarAz 4 37m 1
mina86 3 1d 3h 43m 12
vmarkushin 2 2h 33m 4
0xBrainjar2 2 6h 41m 0
fl-y 1 18h 46m 0
josietyleung 1 26m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4198/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4198/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4198/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4198/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4198/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja marked this pull request as ready for review November 8, 2023 16:15
@RustNinja RustNinja changed the title Liquid staking implementation feat(lsd): Liquid staking Nov 8, 2023
@RustNinja RustNinja changed the title feat(lsd): Liquid staking feat(liquidstaking): Liquid staking for picasso runtime Nov 9, 2023
@RustNinja RustNinja changed the title feat(liquidstaking): Liquid staking for picasso runtime feat(liquidstaking): Liquid staking for picasso and composable runtime Nov 9, 2023
@RustNinja RustNinja requested a review from blasrodri November 9, 2023 15:44
@RustNinja RustNinja merged commit 5306e7f into main Nov 10, 2023
@RustNinja RustNinja deleted the liquid-staking branch November 10, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants