Skip to content

chore: removed not used contracts#4205

Merged
dzmitry-lahoda merged 2 commits intomainfrom
dz/b/17
Oct 19, 2023
Merged

chore: removed not used contracts#4205
dzmitry-lahoda merged 2 commits intomainfrom
dz/b/17

Conversation

@dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Oct 17, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 10 9h 55m 26
RustNinja 9 16h 17m 1
blasrodri 7 18h 49m 6
kkast 6 7h 48m 1
JafarAz 4 37m 1
mina86 3 1d 3h 43m 12
vmarkushin 2 2h 33m 4
0xBrainjar2 2 6h 41m 0
fl-y 1 18h 46m 0
josietyleung 1 26m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4205/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4205/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4205/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4205/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4205/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda
Copy link
Contributor Author

ping @mina86

@dzmitry-lahoda dzmitry-lahoda enabled auto-merge (squash) October 17, 2023 11:04
@dzmitry-lahoda dzmitry-lahoda requested a review from kkast October 17, 2023 11:54
@mina86
Copy link
Contributor

mina86 commented Oct 17, 2023

They are not used at the moment but they are the beginning of the virtual wallet implementation. I don’t see why we're deleting them?

@dzmitry-lahoda
Copy link
Contributor Author

They are not used at the moment but they are the beginning of the virtual wallet implementation. I don’t see why we're deleting them?

@mina86 CVM Executor is Virtual Wallet.

@dzmitry-lahoda
Copy link
Contributor Author

Also I would not maintain xc-core compability with these until this in CI and DevNet.

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>
@dzmitry-lahoda dzmitry-lahoda merged commit b07bc7d into main Oct 19, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/b/17 branch October 19, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants