Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 10 9h 55m 26
RustNinja 10 17h 38m 1
blasrodri 6 14h 34m 1
kkast 6 7h 48m 1
JafarAz 4 37m 1
mina86 3 1d 3h 43m 12
vmarkushin 2 2h 33m 4
0xBrainjar2 2 6h 41m 0
fl-y 1 18h 46m 0
josietyleung 1 26m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4212/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4212/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4212/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4212/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4212/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda changed the title feat: orders demo chore: fixing devnet and renaming cw contracts Oct 17, 2023
@dzmitry-lahoda dzmitry-lahoda changed the title chore: fixing devnet and renaming cw contracts chore: fixing devnet, renaming cw contract, adding cvm docs Oct 17, 2023
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review October 17, 2023 22:23
@dzmitry-lahoda dzmitry-lahoda requested a review from kkast October 17, 2023 22:25
@dzmitry-lahoda
Copy link
Contributor Author

@kkast I force pushing this because now it all broken after PR from you I merged.

@dzmitry-lahoda
Copy link
Contributor Author

Force pushing to unblock my work because of broken devnet

image

@dzmitry-lahoda dzmitry-lahoda merged commit 2254d4f into main Oct 17, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/b/19 branch October 17, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant