Skip to content

Conversation

@kkast
Copy link
Contributor

@kkast kkast commented Nov 6, 2023

Make PICA governance token on picasso:

  1. remove opengovbalances token and clean pallet date
  2. remove democracy and clean pallet date. release locks with id "democrac" for pica
  3. added call filter to disallow blocking of referenda, whitelist, convictionVoting pallets
  4. added new tracks: GeneralAdmin, ReferendaCanceller, ReferendaKiller
  5. changed rights for pallets to remove council and tech committee from making decisions
  6. make council only responsible for treasury decisions
  7. moved relayer to the new RelayerCommittee
  8. fixed tech committee instance gererics for picasso and composable
  9. remove treasury from call filter

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

github-actions bot commented Nov 6, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 13 9h 58m 38
mina86 7 1d 6h 9m 37
RustNinja 6 18h 11m 1
kkast 5 40m 5
vmarkushin 2 2h 24m 2
blasrodri 2 6d 3h 6m 0
JafarAz 2 18h 16m 0
0xBrainjar2 1 6d 8h 19m 11
josietyleung 1 26m 0
bengalmozzi 1 23h 12m 0

@github-actions
Copy link

github-actions bot commented Nov 6, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4283/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4283/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4283/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4283/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4283/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Nov 7, 2023
@dzmitry-lahoda
Copy link
Contributor

let fix xcm first before merge

@kkast kkast requested a review from vmarkushin November 9, 2023 21:55
@kkast kkast merged commit e627fb4 into main Nov 10, 2023
@kkast kkast deleted the open_gov_2 branch November 10, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants