Skip to content

Conversation

@dzmitry-lahoda
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

github-actions bot commented Nov 7, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 13 9h 58m 40
mina86 7 1d 6h 9m 37
RustNinja 7 14h 9m 1
kkast 5 40m 5
vmarkushin 2 2h 24m 2
blasrodri 2 6d 3h 6m 0
0xBrainjar2 2 2d 11h 19m 12
JafarAz 2 18h 16m 0
josietyleung 1 26m 0
bengalmozzi 1 23h 12m 0

@github-actions
Copy link

github-actions bot commented Nov 7, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4293/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4293/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4293/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4293/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4293/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@dzmitry-lahoda dzmitry-lahoda force-pushed the dz/b/46 branch 2 times, most recently from 02a33dc to eb989a0 Compare November 14, 2023 14:06
sharing compiler need too

happy

happy coding

mantis

query

doing

plan
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review November 15, 2023 10:14
@dzmitry-lahoda dzmitry-lahoda changed the title feat(solver): skeleton of solver feat(solver): skeleton of solver with correct cow simulation and folder stucture refactoring and orders clean up fix Nov 15, 2023
@dzmitry-lahoda dzmitry-lahoda merged commit 4fee812 into main Nov 15, 2023
@dzmitry-lahoda dzmitry-lahoda deleted the dz/b/46 branch November 15, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant