Skip to content

Conversation

@RustNinja
Copy link
Contributor

@RustNinja RustNinja commented Nov 15, 2023

  1. Updated origin for XCM helper pallet for picasso runtime
  2. Ensure root for relay origin, general admin or root for update origin in liquid staking pallet config for picasso runtime
  3. Updated composable relay origin for liquid staking pallet

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 14 4h 47m 18
RustNinja 9 7h 21m 14
mina86 7 1d 10h 5m 28
kkast 7 33m 4
0xBrainjar2 3 12h 57m 12
JafarAz 3 15h 5m 1
vmarkushin 2 2h 24m 5
blasrodri 2 6d 3h 6m 0
bengalmozzi 1 23h 12m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4317/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4317/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4317/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4317/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4317/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja enabled auto-merge November 15, 2023 11:50
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is more secure - ok. so not clear if it is opeartional

@RustNinja
Copy link
Contributor Author

it is more secure - ok. so not clear if it is opeartional

so it is exactly the same that other pallets config accept as origin.
so i think it is pretty operational

@RustNinja RustNinja merged commit b2d4b1d into main Nov 15, 2023
@RustNinja RustNinja deleted the lsd-update-origin branch November 15, 2023 12:42
@dzmitry-lahoda
Copy link
Contributor

ypu have put very hard origins, i mean if updates and relay are frequent. you will not be able to operate pallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants