Skip to content

fix(dust): send balance dust from ED to treasury pallet account#4342

Merged
kkast merged 2 commits intomainfrom
kkast/dust_to_treasury
Nov 23, 2023
Merged

fix(dust): send balance dust from ED to treasury pallet account#4342
kkast merged 2 commits intomainfrom
kkast/dust_to_treasury

Conversation

@kkast
Copy link
Contributor

@kkast kkast commented Nov 23, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 12 4h 48m 10
RustNinja 12 7h 21m 14
kkast 9 46m 1
mina86 5 21h 23m 6
0xBrainjar2 4 22h 36m 12
JafarAz 3 15h 5m 1
blasrodri 2 14h 35m 0
vmarkushin 1 2d 14h 2m 3
rjonczy 1 5d 5h 7m 0
bengalmozzi 1 23h 12m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4342/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4342/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4342/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4342/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4342/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja self-requested a review November 23, 2023 09:57
RustNinja
RustNinja previously approved these changes Nov 23, 2023
@dzmitry-lahoda
Copy link
Contributor

fmt

RustNinja
RustNinja previously approved these changes Nov 23, 2023
@kkast kkast merged commit 1833259 into main Nov 23, 2023
@kkast kkast deleted the kkast/dust_to_treasury branch November 23, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants