Conversation
Removes the "parallel libSplash is beta status" note since it is stable and adds some links to interface documentations.
INSTALL.md: Remove "beta" notice for PHDF5
Do not fail if packages were never present on some images.
Travis: Apt-Remove Fix
Adds an example using the `ParallelDataCollector`. Tries to be as close as possible to the "serial" (multiple POSIX files from MPI ranks) example of `mpi_domain_write`.
Close #14 Add PDC Example
C++ catch parameters should be passed by const reference. References: - http://en.cppreference.com/w/cpp/language/try_catch
Removes two `_` prefixes for include guards. This is generally discouraged and reserved, http://www.doc.ic.ac.uk/lab/cplus/c++.rules/chap5.html found via a [flint++](https://github.com/L2Program/FlintPlusPlus) warning.
Include Guards: No _ Prefix
Catch By Reference
Removed via - `sed -i 's/\t/ /g'` (tabs) - `sed -i 's/ *$//'` (EOL white spaces) And then manually fixed some broken python (mixing tabs and spaces in there was quite adventurous). Authored commit as generic tool user: ```bash GIT_AUTHOR_NAME="Tools" GIT_AUTHOR_EMAIL="tools@example.com" git commit ```
Removed via - `sed -i 's/\t/ /g'` (tabs) - `sed -i 's/ *$//'` (EOL white spaces) And then manually fixed license headers (missing paragraph) and include guards. Authored commit as generic tool user: ```bash GIT_AUTHOR_NAME="Tools" GIT_AUTHOR_EMAIL="tools@example.com" git commit ```
Code: Remove Tabs and EOL Spaces
Scripts: Remove Tabs and EOL Spaces
CMakeList.txt: Remove Tabs and EOL Spaces
Add test to check if `readMeta` was successful.
Return the correct, user-selected entry for this iteration and not the first `[0]` entry found.
Fix detection of bool types as correctly put in #198
Fix #224 `readMeta` ColType Detection
ChangeLog for Release 1.3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release contains bug fixes and serveral internal code
clean-ups.
Bug Fixes
readMetanow returns the correctCollectionTypeif more thenone entry was used per iteration, detection for
ColTypeBoolwas broken readMeta: ColType is "Random" (First) #224reference Catch By Reference #213
Misc
_prefixes from a few include guards Include Guards: No _ Prefix #214ParallelDataCollectorclass Parallel Write Example #14