Make filename creation consistent#242
Merged
ax3l merged 9 commits intoComputationalRadiationPhysics:devfrom Jun 22, 2016
Merged
Make filename creation consistent#242ax3l merged 9 commits intoComputationalRadiationPhysics:devfrom
ax3l merged 9 commits intoComputationalRadiationPhysics:devfrom
Conversation
…alRadiationPhysics/dev Release 1.4.0: SDC Global Attibute Path to "/"
Allows passing fullName to SerialDataCollector
Add tests for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows passing full name to SerialDataCollector
Previously the SerialDataCollector created names like "foo.h5_0_0_0.h5" , this is now kept as "foo.h5"
For this it also changes the HandleMgr and extends its filename scheme by FNS_FULLNAME where the name is kept unchanged. Additionally checks where added for catching erroneously passing a full name into the DataCollectors when a base name was expected.
From #234