Skip to content

Fix comparison and docu of generateCollectionType#243

Merged
ax3l merged 5 commits intoComputationalRadiationPhysics:devfrom
Flamefire:memLeak
Jun 22, 2016
Merged

Fix comparison and docu of generateCollectionType#243
ax3l merged 5 commits intoComputationalRadiationPhysics:devfrom
Flamefire:memLeak

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jun 22, 2016

The function returns ColTypeUnknown on not-found.
Also the typeid check is superfluous as the static function genType of that type should per definition return an instance of itself. An assertion is added instead.

In case new genType's are implemented, this will guarantee that no mem-leaks can occur.

@ax3l ax3l added this to the Version 1.5/1.4.X milestone Jun 22, 2016
@ax3l ax3l self-assigned this Jun 22, 2016
@ax3l ax3l merged commit 32dab56 into ComputationalRadiationPhysics:dev Jun 22, 2016
@Flamefire Flamefire deleted the memLeak branch June 4, 2017 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants