Housing Queue Improvements (Solves #103) #105
Conversation
mbillow
force-pushed
the
housing-queue
branch
from
16ac130 to
b579724
Compare
liam-middlebrook
left a comment
liam-middlebrook
left a comment
There was a problem hiding this comment.
Also if you could rebase away the merge commit.
| # get user data | ||
|
|
||
| user_name = request.headers.get('x-webauth-user') | ||
| account = ldap_get_member(user_name) |
There was a problem hiding this comment.
Nitpick: not sure if we've used the language account for this before. But I'd prefer something like current account. That way account can be reserved for some kind of interation
There was a problem hiding this comment.
It was something I choose when transitioning over to the new library. Account is the keyword I chose to denote the passing of the actual object over a string or their username (which we called all sorts of different things [uid, username, user_name, etc]). I am not sure what you mean by integration. Even if we found a better use for the the "account" keyword, having current_account and account being completely different, unrelated possess completely different functionality would be a terrible design choice.
mbillow
force-pushed
the
housing-queue
branch
from
2d3afc6 to
ed3c433
Compare
mbillow
force-pushed
the
housing-queue
branch
from
ed3c433 to
8bb4c81
Compare
Solves #103