Skip to content

Conversation

@nkconnor
Copy link
Contributor

Description

Prior snippet gives

npm ERR! 404 Not found : xml-to-react
npm ERR! 404 
npm ERR! 404  'xml-to-react' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

under npm v4.1.2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore, documentation, cleanup

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Prior snippet gives
npm ERR! 404 Not found : xml-to-react
@coveralls
Copy link

coveralls commented Sep 28, 2018

Pull Request Test Coverage Report for Build 191

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 173: 0.0%
Covered Lines: 60
Relevant Lines: 60

💛 - Coveralls

Copy link
Contributor

@pgoldrbx pgoldrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nkconnor
Copy link
Contributor Author

nkconnor commented Oct 2, 2018

I should probably add more here. With this the imports should be

.... from '@condenast/xml-to-react'

@pgoldrbx
Copy link
Contributor

pgoldrbx commented Oct 2, 2018

Good point. Yeah, if you wouldn't mind updating the rest of the README, that would be excellent. Thanks for the PR!

Copy link
Contributor

@pgoldrbx pgoldrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this!

@pgoldrbx pgoldrbx merged commit 37dbdcd into CondeNast:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants