fix(release): base the dev version on the branch, not the last stable tag - #187
Merged
Conversation
… tag The first dev build called itself 0.3.2-dev. Pipelinq's newest stable tag is v0.3.1 and the beta rule is "one patch above stable", but development's info.xml declares 0.6.0. So the build advertised a version lower than the branch it was cut from, and anyone already running a locally built 0.6.0 would have seen it as a downgrade. A dev build now takes its number straight from the branch's info.xml and does not bump the patch: 0.6.0-dev.<timestamp> is a build *of* 0.6.0 and sorts just below it, which is what a semver prerelease identifier is for. Beta is untouched. It stays one patch ahead of the last stable tag, because that is the version it is heading towards, and the app store orders it against released versions rather than against a branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first dev build called itself 0.3.2-dev. Pipelinq's newest stable tag is
v0.3.1and the beta rule is "one patch above stable" — butdevelopment'sinfo.xmldeclares 0.6.0. So the build advertised a version lower than the branch it was cut from, and anyone running a locally built 0.6.0 would have seen it as a downgrade.A dev build now takes its number straight from the branch's
info.xmland does not bump the patch:0.6.0-dev.<timestamp>is a build of 0.6.0 and sorts just below it, which is what a semver prerelease identifier is for.Beta is untouched. It stays one patch ahead of the last stable tag, because that is the version it is heading towards, and the app store orders it against released versions rather than against a branch.
Follows #186.