fix(gates 12-22): four gates could not detect the defect they exist for, and gate-20 had never fired at all

[rubenvdlinde]

What was measured

Every gate in the 12–22 band was given one textbook true positive of exactly what it exists to catch, in a real fleet repo whose shape suits it, and asked to catch it. Then the plant was removed and the gate had to return to its exact prior verdict, and a clean repo had to stay clean.

Baseline package cdfbd7ab ([hydra-gates] gate package: cdfbd7ab1e28d8619fafa6cf772b0013ca4f9595); re-measured on top of fef032b (#272) at 6f9490f9.

Subjects: openregister (207 .vue, 794 spec scenarios, lib/Settings/*register*.json), pipelinq (202 .vue, six type:"dashboard" pages), shillinq (an ADR-040 AppHost adopter that keeps its own SettingsController), and an nldesign-shaped fixture whose src/ holds a single manifest.json.

Gate	Planted true positive	Fired?	Repaired
12 nc-input-labels	<NcSelect :reduce="(option) => option.value" />, no input-label	✅ names the file	➕ na instead of PASS on a src/ with zero .vue
13 modal-isolation	inline <NcModal> in src/views/	✅	➕ same
14 route-reachability	(a) unrouted JSONResponse method (b) route → missing method (c) settings#update deleted from an AppHost adopter	✅ ✅ ❌ (c)	✅ #265 closed
15 dashboard-antipattern	<CnDashboardPage> inside a #widget-<id> slot	✅	✅ crashed-checker → PASS; attribute-order blind spot
16 spec-coverage	changed public method with no @spec	✅ names 2, and correctly skips the sibling that has one	✅ crashed-checker → PASS
17 redundant-controller	fetchAll() { return new JSONResponse($this->objectService->findAll([])); }	❌ PASS	✅ two causes
18 notification-dialect	legacy dialect block in a register JSON	✅ names all 7 tokens	✅ crashed-checker → PASS
19 e2e-coverage	new #### Scenario: with no @e2e	✅ names it; exit is a status, 794 findings → exit 1	✅ crashed-checker → FAIL with an unmeasured count
20 or-objectservice-api	$this->objectService->findObjects(...)	❌ PASS — and it had never fired anywhere, ever	✅
21 conflict-markers	real <<<<<<</=======/>>>>>>> in lib/*.php	✅ — and not on a .md that documents them	—
22 manifest-validation	invalid page type + additional property	✅ names both at /pages/0…	✅ verdict depended on checkout layout

The four that could not detect their own subject

1. gate-20 had never fired. Not rarely — never.

grep -nE "->${_pat//(/\\(}" "${_file}"          # pattern expands to  ->findObjects\(
$ grep -nE "->findObjects\(" ActionsController.php
grep: invalid option -- '>'                      # exit 2, no output

The pattern begins with -, so grep parses it as options. 2>/dev/null || true discarded both the message and the status, so every file came back with zero hits and the gate printed PASS everywhere in the fleet.

Repairing the grep alone is not the fix. The receiver test was "the file mentions ObjectService somewhere", and with the grep working that produces 14 findings on openregister and 5 on shillinq, all false — createFromArray() is a real method on OpenRegister's Mappers. The receiver is now part of the pattern. Fleet measurement across the three repos afterwards: one finding, and it is real — shillinq's BookingNotificationController resolves OCA\OpenRegister\Service\ObjectService from the container inside its non-admin authorisation guard and calls findObject(), which does not exist on it. A BadMethodCallException in an auth guard, shipped.

2. gate-17 was wrong about the same API, in the other direction.

Four of the six names in OBJECT_SERVICE_CRUD — findObjects, createFromArray, updateFromArray, deleteFromId — do not exist on ObjectService; they are precisely what gate-20 flags as fabricated. findAll / createObject / updateObject / deleteObject were absent. And ^\s*return\s+new\s+JSONResponse sits in WRAPPER_NOISE_PATTERNS, tested before the ObjectService check — so the commonest pass-through spelling of all was discarded as "response wrapping" with the call still inside it, then matched by RESCUE_PATTERNS' \$this->\w+Service->\w+\( and returned False. The gate rescued its own subject.

3. gate-14 never judged the ten routes AppHost supplies (#265).

#223 taught invariant 1 about Routes::standard(); invariant 2 asks the opposite question and still read route names as literals out of the leaf's own appinfo/routes.php, where those ten names never appear. Deleting SettingsController::update() from shillinq — which keeps its own controller, as aliasControllerUnlessLeafDefinesIt explicitly allows — leaves PUT /api/settings resolving to nothing. Not a 404: the router matches, ControllerMethodReflector reflects, the request dies 500. shillinq's own docblock on update() spells the hazard out. Gate-14's findings log came back empty.

4. Three gates reported PASS over a crashed checker.

With python3 replaced by a stub that always exits 1 — so not one file was inspected by any python-backed gate:

gate-12 SKIPPED (wiring)     gate-15 PASS
gate-17 SKIPPED (wiring)     gate-16 PASS
                             gate-18 PASS
                             gate-19 FAIL — "an unreported number of scenario(s)"

15/16/18 wrote 2>/dev/null || true and counted lines in an empty log. 19 read exit 1 as EXIT_FAIL from a helper that never printed its own summary — a blocking verdict carrying a count nobody measured.

Two more, found on the way

gates 12 and 13 passed over a src/ with zero .vue (#274). [ -d src ] is not "src/ contains a Vue component". At fef032b both print PASS on an nldesign-shaped repo — the shape that let twelve gates certify nldesign in #225. Not one rm away: current. Now na, with the judgement #274 asked for written down — NcSelect/NcModal/NcDialog are Vue SFC components, a PHP template cannot instantiate one, so these two stay .vue-only and gate-40 keeps the language-agnostic rule for templates/.

gate-22's verdict depended on where the gates were checked out. require('ajv/dist/2020') resolves relative to check_manifest.js, never to the repo under test. Run from openregister's own root with node_modules/ajv present in that root, the validator printed "Ajv is not resolvable from this process (no node_modules, no NODE_PATH)" — false — and gate-22 went FAIL; exporting NODE_PATH to that same directory flipped it to PASS. Resolution is now anchored on the manifest's own repo root, then cwd, then this package, and the degradation names every directory it searched.

gate-15's slot matcher had gate-44's blind spot. <template #widget-x class="wide"> and <template #widget-x='{i}'> did not match — the pattern assumed the slot binding was the last thing before >.

Anti-widening

Every repair ships with the sibling that must stay silent:

• gate-20: a mapper's real createFromArray() in a file that mentions ObjectService → not flagged. Blast radius across openregister/pipelinq/shillinq: 1 finding, genuine.
• gate-17: a domain-named method with a byte-identical body → not flagged. Blast radius: 0 new findings.
• gate-14: the other nine canonical AppHost names still resolve; routes-standard/ still yields exactly one finding.
• gates 12/13: add one .vue carrying the defect and both go straight back to FAIL.
• gate-18: a working python3 on the same fixture still FAILs the planted legacy dialect.
• gate-21: a .md that documents conflict markers is not flagged.
• pipelinq, clean, whole repo: byte-identical verdicts before and after across all eleven gates.

Tests — all mutation-checked

Suite	Red against pre-fix
test_gate_or_objectservice_surface.sh (new)	gate-20 + gate-17, each with its silent sibling, plus a direct assertion that a --leading grep pattern is parsed as options
test_gate_crashed_checker_is_not_a_finding.sh	7 failures at cdfbd7a — all six python-backed gates under a broken interpreter, asserted generically so a future gate inherits it
test_gate_empty_scope_never_passes.sh	3 failures at fef032b — gates 12/13 on the nldesign shape, with the one-.vue control
test_gate_route_registration.sh	new fixture routes-standard-missing-update/, differing from its sibling by exactly the deleted method
test_check_manifest.sh	ajv anchor red pre-fix
test_check_dashboard_antipattern.py	4 subtests — slot-tag spellings that were silent misses

50 helper suites pass (2 quarantined, unchanged), 59 bin-level assertions pass.

Verdicts will move

gate-20 and gate-17 can now produce findings in repos that were green — starting with the shillinq auth-guard call above. Gates 12/13/15/16/18/19 can now report SKIPPED (wiring) or NOT APPLICABLE, neither of which is a pass.

Closes #265. Closes the gate-12 half of #274.