docs(runner): quote the misleading preamble line instead of misdirecting to it - #419
Merged
Conversation
…, not above Comment-only. The block said the misleading sentence appears "four lines above"; it is emitted further down, once the base resolves. A comment that misdirects the reader to the wrong line is the same defect class this file is about — a claim nobody can check against the thing it names — so it now quotes the sentence instead of pointing at a location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only follow-up to #418.
That PR auto-merged the moment its checks went green, at
b8c53a2— before this correction reached the branch. Nothing about the fix changes; stripping comments and blank lines fromrun-hydra-gates.shgives the same md5 (fa41262d8d67a4386bf04c5ba3732876) onmainand on this branch.What is wrong on
main. The new comment block says the misleading sentence appears "four lines above". It does not — it is emitted further down, once the base resolves. A comment that sends the reader to the wrong line is the same defect class the block is about: a claim nobody can check against the thing it names. It now quotes the sentence instead of pointing at a location.