fix(release): correct the app id and Node version so releases can work - #131
Merged
Conversation
Contributor
Quality Report — ConductionNL/app-versions @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ❌ | ||||
| composer | ✅ | ✅ 17/17 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 11:29 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Versions has no releases at all, despite having had release workflows for a while. Two reasons, both in the callers:
The app id was wrong. They passed
app-name: app-versions(hyphen) whileappinfo/info.xmldeclaresapp_versions(underscore). The packaged directory is named after this input, and Nextcloud refuses an app whose folder does not match its id — so even a successful build would have produced an unusable tarball.Node 18 cannot build the frontend. The shared workflow defaults to Node 18; this app is Vite 7 with
engines.node ^24.0.0. The build fails there and succeeds locally, which is exactly the shape of failure nobody investigates. Confirmed:npm run buildexits 0 locally on Node 22.Also adds the development channel, so there is a downloadable artifact at all. That matters more here than elsewhere: App Versions is the app that installs other apps, so until it can be put on an instance, none of the development builds we just started publishing can be installed with it.