release: promote the enable fix to beta - #135
Merged
Merged
Conversation
…be enabled (#134) Every app installed through App Versions could be installed but not enabled. `occ app:enable <app>` died with conflict between new type (mixed) and old type (string) which reads like a schema problem and is not one. It appeared on a completely clean Nextcloud, which is the tell: there was no old schema to conflict with. Since Nextcloud 29 each appconfig row carries a type, and core only accepts a write whose type differs from the stored one when the stored type is VALUE_MIXED. Core writes installed_version, enabled, types and its own remote_/public_ routes through the untyped IConfig::setAppValue(), so those rows are MIXED. The finalizer wrote them with setValueString(), leaving VALUE_STRING rows that core could no longer update, so the very next enable threw. Confirmed by comparing an app installed normally against one installed through App Versions: files had type=2 (MIXED) on those keys, pipelinq had type=4 (STRING). Core's keys now go through setAppValue(), matching core exactly. IConfig::setAppValue is deprecated, but it is the only public API that writes untyped, and matching core's type is the whole point. Config this app owns stays on the typed API. Verified on a clean Nextcloud 31: install pipelinq 0.6.0-dev through App Versions, then `occ app:enable pipelinq` succeeds, and its installed_version/enabled/types rows are type=2 exactly like files. Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Contributor
Quality Report — ConductionNL/app-versions @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ❌ | ||||
| composer | ✅ | ✅ 17/17 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-06 13:03 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #134. Without it, every app installed through App Versions can be installed but not enabled, which is most of the point of the app.