chore(deps): Bump vue from 3.5.29 to 3.5.33 - #21
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [vue](https://github.com/vuejs/core) from 3.5.29 to 3.5.33. - [Release notes](https://github.com/vuejs/core/releases) - [Changelog](https://github.com/vuejs/core/blob/main/CHANGELOG.md) - [Commits](vuejs/core@v3.5.29...v3.5.33) --- updated-dependencies: - dependency-name: vue dependency-version: 3.5.33 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
MWest2020
pushed a commit
that referenced
this pull request
Jul 16, 2026
…t hygiene F1 (blocker) — InstallerService::resolveBinding was gating assertBindingAllowed() on `kind === KIND_GITHUB_RELEASE` at two spots (lines 335 and 344), silently disabling the allowlist for the new KIND_GITEA_RELEASE on the read path. `bindSource()` (write path) was already unconditional, but `sourceOverride` on the read side and already-stored gitea bindings both bypassed the trust list — which broke TrustedSourceList's documented contract for the exact security control this PR extended. Fix: drop the kind gate entirely, always call assertBindingAllowed(). The primitive short-circuits appstore internally via extractIdentifier() returning null, so unconditional invocation is safe and future-proof against new source kinds. Regression suite: new tests/unit/Service/Source/InstallerServiceBindingGuardTest uses ReflectionMethod to exercise the private resolveBinding across 6 scenarios: untrusted gitea + github overrides both throw; trusted gitea override passes; stored untrusted gitea binding is rejected on read; stored trusted gitea binding is accepted; appstore fallback skips the guard. Non-blocking follow-ups from the same review: F2 — Doc-comment on the `limit=50` cap in GiteaReleaseSource::fetchReleases explaining that Gitea/Forgejo caps `limit` at 50 for /releases where GitHub allows 100 via `per_page`, and that a repo with >50 releases would truncate here (Nextcloud apps ship <20 in practice). F3 — CHANGELOG [1.1.0] gets its release date (2026-07-09) per Keep-a-Changelog convention. F4 — New test `testEndpointUrlIsBuiltFromBindingHost` uses $client->expects->with->stringContains to lock in three properties of the built endpoint: `https://` scheme, host propagation from the binding, and `/api/v1/repos/…/releases` path prefix. F5 — SourceInterface::resolveRelease docstring updated to document the gitea-release payload shape alongside App Store and GitHub. F6 — Inline comments in listVersions() and resolveRelease() explain why we filter `draft: true` where GithubReleaseSource doesn't (GitHub hides drafts server-side to anonymous consumers; some Gitea/ Forgejo versions surface them, so defensive parity with the release- page UI). Suite: 121 tests / 283 assertions, all green (was 114 / 266). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MWest2020
pushed a commit
that referenced
this pull request
Jul 16, 2026
…odeberg, self-hosted Gitea)' (#21) from feat/gitea-release-source into main Reviewed-on: https://codeberg.org/Conduction/app-versions/pulls/21
MWest2020
pushed a commit
that referenced
this pull request
Jul 16, 2026
Adds an admin-only UI affordance to switch an installed app's release
source between App Store, Codeberg/Gitea, and GitHub without leaving the
picker — the /api/source/{appId}/bind endpoint was already there since
PR #21 but had no frontend.
**Info panel (per selected app)**
- New "Version source" card showing the current binding label, e.g.
`Codeberg / Gitea (codeberg.org/Conduction/opencatalogi)`.
- Four buttons: App Store · Codeberg · GitHub · Advanced… — active
binding gets a highlight (Codeberg quick-switch has a blue accent to
signal "recommended" per PR #24).
- Codeberg quick-switch posts `{host:codeberg.org, owner:Conduction,
repo:{appId}}`; GitHub quick-switch posts `{owner:ConductionNL,
repo:{appId}}`; both use assetPattern `*.tar.gz`.
**Advanced dialog (NcDialog)**
- Full form for overrides: source kind, host (Gitea only), owner, repo,
assetPattern. Pre-populates from the current binding when one exists;
otherwise defaults to Codeberg + {appId}.
- Inline validation hint + error surface for the bind response.
**Wiring**
- New helpers: loadSources, loadCurrentBinding, submitBind,
quickBindCodeberg / quickBindGithub / quickBindAppStore.
- Honors PasswordConfirmationRequired via the existing
ensurePasswordConfirmation helper.
- On successful bind, re-runs checkVersions so the picker immediately
reflects the new source.
**Notes**
- Pure frontend change — no PHP or spec changes; the /bind route was
already fully documented in openapi.json and the admin tutorial added
in PR #23.
- Backwards-compatible: if /api/source/{appId}/binding returns null
(never bound), the UI shows "Nextcloud App Store" and the App Store
quick-switch button as active.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rubenvdlinde
pushed a commit
that referenced
this pull request
Jul 23, 2026
…t hygiene F1 (blocker) — InstallerService::resolveBinding was gating assertBindingAllowed() on `kind === KIND_GITHUB_RELEASE` at two spots (lines 335 and 344), silently disabling the allowlist for the new KIND_GITEA_RELEASE on the read path. `bindSource()` (write path) was already unconditional, but `sourceOverride` on the read side and already-stored gitea bindings both bypassed the trust list — which broke TrustedSourceList's documented contract for the exact security control this PR extended. Fix: drop the kind gate entirely, always call assertBindingAllowed(). The primitive short-circuits appstore internally via extractIdentifier() returning null, so unconditional invocation is safe and future-proof against new source kinds. Regression suite: new tests/unit/Service/Source/InstallerServiceBindingGuardTest uses ReflectionMethod to exercise the private resolveBinding across 6 scenarios: untrusted gitea + github overrides both throw; trusted gitea override passes; stored untrusted gitea binding is rejected on read; stored trusted gitea binding is accepted; appstore fallback skips the guard. Non-blocking follow-ups from the same review: F2 — Doc-comment on the `limit=50` cap in GiteaReleaseSource::fetchReleases explaining that Gitea/Forgejo caps `limit` at 50 for /releases where GitHub allows 100 via `per_page`, and that a repo with >50 releases would truncate here (Nextcloud apps ship <20 in practice). F3 — CHANGELOG [1.1.0] gets its release date (2026-07-09) per Keep-a-Changelog convention. F4 — New test `testEndpointUrlIsBuiltFromBindingHost` uses $client->expects->with->stringContains to lock in three properties of the built endpoint: `https://` scheme, host propagation from the binding, and `/api/v1/repos/…/releases` path prefix. F5 — SourceInterface::resolveRelease docstring updated to document the gitea-release payload shape alongside App Store and GitHub. F6 — Inline comments in listVersions() and resolveRelease() explain why we filter `draft: true` where GithubReleaseSource doesn't (GitHub hides drafts server-side to anonymous consumers; some Gitea/ Forgejo versions surface them, so defensive parity with the release- page UI). Suite: 121 tests / 283 assertions, all green (was 114 / 266). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rubenvdlinde
pushed a commit
that referenced
this pull request
Jul 23, 2026
…odeberg, self-hosted Gitea)' (#21) from feat/gitea-release-source into main Reviewed-on: https://codeberg.org/Conduction/app-versions/pulls/21
rubenvdlinde
pushed a commit
that referenced
this pull request
Jul 23, 2026
Adds an admin-only UI affordance to switch an installed app's release
source between App Store, Codeberg/Gitea, and GitHub without leaving the
picker — the /api/source/{appId}/bind endpoint was already there since
PR #21 but had no frontend.
**Info panel (per selected app)**
- New "Version source" card showing the current binding label, e.g.
`Codeberg / Gitea (codeberg.org/Conduction/opencatalogi)`.
- Four buttons: App Store · Codeberg · GitHub · Advanced… — active
binding gets a highlight (Codeberg quick-switch has a blue accent to
signal "recommended" per PR #24).
- Codeberg quick-switch posts `{host:codeberg.org, owner:Conduction,
repo:{appId}}`; GitHub quick-switch posts `{owner:ConductionNL,
repo:{appId}}`; both use assetPattern `*.tar.gz`.
**Advanced dialog (NcDialog)**
- Full form for overrides: source kind, host (Gitea only), owner, repo,
assetPattern. Pre-populates from the current binding when one exists;
otherwise defaults to Codeberg + {appId}.
- Inline validation hint + error surface for the bind response.
**Wiring**
- New helpers: loadSources, loadCurrentBinding, submitBind,
quickBindCodeberg / quickBindGithub / quickBindAppStore.
- Honors PasswordConfirmationRequired via the existing
ensurePasswordConfirmation helper.
- On successful bind, re-runs checkVersions so the picker immediately
reflects the new source.
**Notes**
- Pure frontend change — no PHP or spec changes; the /bind route was
already fully documented in openapi.json and the admin tutorial added
in PR #23.
- Backwards-compatible: if /api/source/{appId}/binding returns null
(never bound), the UI shows "Nextcloud App Store" and the App Store
quick-switch button as active.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vue from 3.5.29 to 3.5.33.
Release notes
Sourced from vue's releases.
Changelog
Sourced from vue's changelog.
... (truncated)
Commits
3310eearelease: v3.5.33bb9d265fix(compiler-sfc): handle nested :deep in selector pseudos (#14725)60402cdRevert "chore(deps): update pnpm/action-setup action to v6" (#14749)11fb2fdfix(runtime-dom): preserve textarea resize dimensions (#14747)974e2d2chore(deps): update test (#14713)45990cefix(transition): preserve placeholder for conditional explicit default slots ...6a61f44fix(teleport): don't move teleport children if not mounted (#14702)e7659befix(reactivity): unlink effect scopes on out-of-order off (#14734)268115dchore: update pnpm config (#14694)24f26f4chore(deps): update pnpm/action-setup action to v6 (#14716)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)