docs(gate-16): document onSettingsOpen's lazy flow load - #480
Merged
Conversation
gate-16 failed the development->beta release PR (#476) on one changed method missing @SPEC: ApplicationDetailActions.vue::onSettingsOpen. It is real behaviour, not glue, so it gets a real @SPEC rather than an exclusion -- the same application-detail-ui spec its sibling setFlows already carries. The docblock records why the fetch is lazy (the flows are read only inside this modal, and most visits never open it) and what the three guards buy: the request happens exactly once, never on close, never when a previous open already filled the list, never while one is in flight. Verified with the real gate (ConductionNL/.github check_spec_coverage.py) against origin/beta: count=1 before, count=0 after.
Contributor
Quality Report — ConductionNL/buildiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| check-gitignore | ✅ | ||||
| check-nc-floor | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 642/642 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-27 10:24 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
pushed a commit
that referenced
this pull request
Aug 27, 2026
Brings development's onSettingsOpen annotation across, which is what the release PR's Hydra Gates leg was failing on. The only conflict was the version line again: beta's 0.6.2-beta.20260820211351 is kept over development's lower 0.6.1-unstable, so the release is not a downgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate-16 failed the development->beta release PR (#476) on one changed method missing
@spec:ApplicationDetailActions.vue::onSettingsOpen.It is real behaviour, not glue, so it gets a real
@specrather than an exclusion — the sameapplication-detail-uispec its siblingsetFlowsalready carries. The docblock records why the fetch is lazy (the flows are read only inside this modal, and most visits never open it) and what the three guards buy: the request happens exactly once, never on close, never when a previous open already filled the list, never while one is in flight.Verified with the real gate (
ConductionNL/.githubcheck_spec_coverage.py) againstorigin/beta: count=1 before, count=0 after.