feat(walkthrough): show where flows live, without making anyone build one - #513
Merged
Conversation
… one buildiq ships a Flows page and its tour never mentioned it, so the automation surface was discoverable only to someone who already knew it was there. This is the last of the fleet apps to get the stop; the other eight landed today. The step is `optional` with `allowManualNext`, deliberately: showing where flows are edited must not turn into "author an automation before you may finish the tour". Also bumps @conduction/nextcloud-vue to 2.21.0. That is not housekeeping — it is what makes the step work at all. The stop targets `Flows`, a SETTINGS-section nav entry, and CnAppNav did not emit `data-cn-route` on its settings loop until 2.21.0 (#811). Below that the target resolves to nothing, and CnWalkthrough SKIPS an optional step whose target is absent — silently, with the step counter unchanged. The step would have shipped and reached nobody. `npm ci` installs from the lock, so the caret range alone decides nothing. The three new strings are added to l10n/en.json and nl.json by hand: buildiq's own `test:l10n` does not read src/manifest.json (it reports OK with all three missing), so gate-101 in CI is the only thing that would have caught it. Verified: gate-70 rc=0 (0 findings), gate-96 rc=0, test:l10n OK, check:l10n-js rc=0.
Contributor
Quality Report — ConductionNL/buildiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| check-gitignore | ✅ | ||||
| check-nc-floor | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 642/642 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-28 12:35 UTC
Download the full PDF report from the workflow artifacts.
gate-100 was CORRECTED on 2026-08-28. Its first version demanded `demo-data` at step 0 and treated `welcome` as "a question nobody asked"; the corrected rule puts `welcome` first and the demo-data offer second, because the setup wizard is the CONFIGURATION wizard and an orientation step earns its place there. buildiq led with `demo-data`, which the OLD rule called compliant and the corrected one fails. That ordering predates this branch — this PR only adds the Flows walkthrough stop — but gate-100 is diff-scoped on src/manifest.json, so touching the manifest at all pulls the setup declaration into scope. Fixing it here rather than leaving the branch red over an ordering it did not introduce. Nothing else changes: same five steps, same actions, same copy. Verified against the CURRENT checker (re-extracted from .github main — the copy I had cached was the pre-correction one and reported the opposite verdict): gate-100 rc=0, gate-70 0 findings, gate-96 rc=0, test:l10n rc=0.
Contributor
Quality Report — ConductionNL/buildiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| check-gitignore | ✅ | ||||
| check-nc-floor | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 642/642 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | 🚨 NO VERDICT — enabled but never ran | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 12:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(walkthrough): show where flows live, without making anyone build one
buildiq ships a Flows page and its tour never mentioned it, so the
automation surface was discoverable only to someone who already knew it was
there. This is the last of the fleet apps to get the stop; the other eight
landed today.
The step is
optionalwithallowManualNext, deliberately: showing whereflows are edited must not turn into "author an automation before you may
finish the tour".
Also bumps @conduction/nextcloud-vue to 2.21.0. That is not housekeeping —
it is what makes the step work at all. The stop targets
Flows, aSETTINGS-section nav entry, and CnAppNav did not emit
data-cn-routeon itssettings loop until 2.21.0 (#811). Below that the target resolves to
nothing, and CnWalkthrough SKIPS an optional step whose target is absent —
silently, with the step counter unchanged. The step would have shipped and
reached nobody.
npm ciinstalls from the lock, so the caret range alonedecides nothing.
The three new strings are added to l10n/en.json and nl.json by hand:
buildiq's own
test:l10ndoes not read src/manifest.json (it reports OKwith all three missing), so gate-101 in CI is the only thing that would
have caught it.
Verified: gate-70 rc=0 (0 findings), gate-96 rc=0, test:l10n OK,
check:l10n-js rc=0.