fix(quality): raise .coverage-baseline to the value actually measured on development - #379
Merged
Merged
Conversation
…opment The initial 52.88 was read from the most recent coverage-report artifact, which turned out to be a pull_request run of a DIFFERENT branch: 10961 statements against development's 16778. Recency is not provenance. 61.39 (10300/16778) comes from run 30925515438 - push, development, sha 2a660aa - verified by the artifact's workflow_run.head_branch and head_sha rather than by being newest. The gate caught this on its first ever execution.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 4, 2026 19:18
Contributor
Quality Report — ConductionNL/docudesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| test | ✅ | ||||
| test-unit | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 647/647 | |||
| PHPUnit | ✅ | ||||
| Newman | ❌ | ||||
| Playwright | ✅ |
Quality workflow — 2026-08-04 19:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises
.coverage-baselinefrom52.88to61.39, closing theCoverage Baseline Checkfailure ondevelopment.Why the first value was wrong — and it is a trap worth writing down
.coverage-baselinewas introduced yesterday at52.88, taken fromclover.xmlin the most recentcoverage-reportartifact at the time. Thatwas the mistake:
coverage-reportis uploaded by every run that has PHPUnitenabled, on any branch, and "the latest artifact" was a pull_request run of
a different branch with a different app/matrix combination.
The statement universes make it obvious in hindsight:
development, sha2a660aacSame repo, same day, 5 817 more statements — not a coverage change, a
different measurement. Picking an artifact by name and recency reads whatever
ran most recently anywhere, and nothing about the file says which branch it came
from.
The gate caught this on its first ever execution, which is exactly what it is
for: it hard-failed with
measured coverage has improved past itrather thanletting a too-low ratchet sit there permanently under-protecting the repo.
The value here is read from the
coverage-reportartifact of the push run ondevelopmentat the current head sha — verified by.workflow_run.head_branchand.workflow_run.head_sha, not by recency.Note on the error message you will have seen
The failing job says to commit "the recomputed value (attached as the
coverage-baselineartifact of this run)". That artifact does not exist —.coverage-baselineis a dotfile andactions/upload-artifact@v4skips hiddenfiles by default, warning instead of failing. Fixed fleet-wide in
ConductionNL/.github#156. The number here therefore comes from the clover file
coverage-guard.phpitself parses.Coverage Baseline Protectionaccepts any value that does not LOWER thebaseline, so this raise passes the PR-side gate.