fix: replace standalone SBOM with reusable quality workflow - #42
Closed
rubenvdlinde wants to merge 6 commits into
Closed
fix: replace standalone SBOM with reusable quality workflow#42rubenvdlinde wants to merge 6 commits into
rubenvdlinde wants to merge 6 commits into
Conversation
Take version from development (0.0.34-unstable.8) and keep the reusable SBOM workflow from this branch.
Replace standalone code-quality.yml and sbom.yml with a single reusable workflow caller from ConductionNL/.github that handles PHP quality checks, frontend linting, and SBOM generation.
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
npm dependencies (324 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
Contributor
Author
|
Closing — superseded by newer work or stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the CI quality workflows into a single reusable workflow caller:
code-quality.yml(71 lines of custom PHP checks + frontend linting) with a call to the sharedConductionNL/.githubreusable quality workflowsbom.yml— its functionality (enable-sbom: true) is now included in the consolidatedcode-quality.ymlcode-quality.yml) that callsConductionNL/.github/.github/workflows/quality.yml@mainwithenable-sbom: trueandenable-frontend: true, covering both push and PR triggersNote: This branch was based on
mainafter merge of #38, so the diff againstdevelopmentincludes many unrelated file changes from the divergence betweenmainanddevelopment. The only intentional changes are to the workflow files and the version bump.Commits
a48088aMerge pull request chore: Merge development into main #38 from ConductionNL/developmentc293e40Bump version to 0.0.33 [skip ci]3928c27fix: replace standalone SBOM workflow with reusable quality workflowacf4e8ffix: Resolve merge conflicts with development branch3c8751efix: consolidate quality workflows into single reusable workflowRelated
Test plan
mainanddevelopmentmainanddevelopment