chore(deps): take nextcloud-vue 2.20.0, so the flow editor fixes actually arrive - #1400
Merged
Merged
Conversation
…ally arrive The range was already `^2.19.0`, which permits 2.20.0 — so nothing about the range was blocking this. `package-lock.json` pinned 2.19.0, and the lock is what installs. A permissive caret proves nothing on its own. 2.20.0 is what makes the reported flow-editor behaviour real on this app: one container per node instead of three, arrowheads showing direction, a per-step action menu, Delete/Backspace, Ctrl+Z, a cron builder and a run-as user picker in place of a raw JSON box. Verified rather than assumed: - the lock diff is exactly ONE package entry, 2.19.0 -> 2.20.0 - `npm ci` clean, and 2.20.0 is what lands in node_modules - `npm run build` exits 0 - the fixes are present in the BUILT bundles, not just in source — a check that reads source cannot see the artefact the browser loads - 33 test files / 343 unit tests pass
…hand #1399 ("development cannot npm install") rewrote package-lock.json under this branch. A lock conflict must never be hand-merged — the resolution is to take development's file wholesale and re-run the bump on top of it, so the lock is one npm has actually computed rather than one a human stitched together from two sides of a conflict.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 552/552 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-27 15:34 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 552/552 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-27 18:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the loop on the flow-editor report: the fixes are released, and this is what lets this app receive them.
Why the range was never the problem
package.jsonalready said^2.19.0, which permits 2.20.0. What pinned the app waspackage-lock.jsonat 2.19.0 — and the lock is what installs. A permissive caret proves nothing on its own; measured across the workspace, 21 checkouts sit in exactly this position.What 2.20.0 brings to this app
markerEndwas set all along and rendered 12.5px at the path end, exactly under the target's 18px port handle, in a layer painted above the edges.)0 9 * * 1, and a run-as picker, in place of the raw JSON box.Verification
Not assumed from the version number:
npm cinode_modulesnpm run buildarrowclosed,undoStack,describeCron,nodeMenuActionsall presentThe bundle check is the one that counts: a check that reads source cannot see the artefact the browser loads, and this app ships webpack chunks, not source.
--legacy-peer-depsanywhere — it uninstalls peers and would have invalidated the whole comparison.