Skip to content

chore(deps): take nextcloud-vue 2.20.0, so the flow editor fixes actually arrive - #1400

Merged
rubenvdlinde merged 2 commits into
developmentfrom
chore/nextcloud-vue-2.20.0
Aug 27, 2026
Merged

chore(deps): take nextcloud-vue 2.20.0, so the flow editor fixes actually arrive#1400
rubenvdlinde merged 2 commits into
developmentfrom
chore/nextcloud-vue-2.20.0

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Closes the loop on the flow-editor report: the fixes are released, and this is what lets this app receive them.

Why the range was never the problem

package.json already said ^2.19.0, which permits 2.20.0. What pinned the app was package-lock.json at 2.19.0 — and the lock is what installs. A permissive caret proves nothing on its own; measured across the workspace, 21 checkouts sit in exactly this position.

What 2.20.0 brings to this app

  • One container per node, instead of three nested boxes.
  • Arrowheads on the edges, so data direction is visible. (These were never actually missing — markerEnd was set all along and rendered 12.5px at the path end, exactly under the target's 18px port handle, in a layer painted above the edges.)
  • A per-step action menu (Edit / Copy / Delete), replacing the sidebar.
  • Delete and Backspace on a selected node — both, since which one deletes is a platform habit.
  • Ctrl+Z, which stands down inside text inputs so it never reverts a graph over a typo.
  • A cron builder reading "Every Monday at 09:00" rather than 0 9 * * 1, and a run-as picker, in place of the raw JSON box.

Verification

Not assumed from the version number:

Check Result
Lock diff scope exactly 1 package entry, 2.19.0 → 2.20.0
npm ci clean; 2.20.0 is what lands in node_modules
npm run build exit 0
Fixes in the built bundles arrowclosed, undoStack, describeCron, nodeMenuActions all present
Unit tests 33 files / 343 tests, all passing

The bundle check is the one that counts: a check that reads source cannot see the artefact the browser loads, and this app ships webpack chunks, not source.

⚠️ No --legacy-peer-deps anywhere — it uninstalls peers and would have invalidated the whole comparison.

…ally arrive

The range was already `^2.19.0`, which permits 2.20.0 — so nothing about
the range was blocking this. `package-lock.json` pinned 2.19.0, and the
lock is what installs. A permissive caret proves nothing on its own.

2.20.0 is what makes the reported flow-editor behaviour real on this app:
one container per node instead of three, arrowheads showing direction,
a per-step action menu, Delete/Backspace, Ctrl+Z, a cron builder and a
run-as user picker in place of a raw JSON box.

Verified rather than assumed:

- the lock diff is exactly ONE package entry, 2.19.0 -> 2.20.0
- `npm ci` clean, and 2.20.0 is what lands in node_modules
- `npm run build` exits 0
- the fixes are present in the BUILT bundles, not just in source — a
  check that reads source cannot see the artefact the browser loads
- 33 test files / 343 unit tests pass
…hand

#1399 ("development cannot npm install") rewrote package-lock.json under
this branch. A lock conflict must never be hand-merged — the resolution is
to take development's file wholesale and re-run the bump on top of it, so
the lock is one npm has actually computed rather than one a human stitched
together from two sides of a conflict.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 5d84319

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue3-compile
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 106/106
npm ✅ 552/552
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman ⏭️
Playwright
Hydra gates

Quality workflow — 2026-08-27 15:34 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 9421077 into development Aug 27, 2026
83 checks passed
@rubenvdlinde
rubenvdlinde deleted the chore/nextcloud-vue-2.20.0 branch August 27, 2026 16:38
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ 41b61ee

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue3-compile
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 106/106
npm ✅ 552/552
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman ⏭️
Playwright
Hydra gates

Quality workflow — 2026-08-27 18:44 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant