fix(e2e): the navigation spec still asserted the Reports submenu - #1617
Merged
rubenvdlinde merged 1 commit intoSep 1, 2026
Merged
Conversation
dossiq#1583 retired the three report leaves and replaced them with one Reports page of cards (ADR-112). navigation.spec.ts asserts every nav link it expects, so it went red on development the moment that merged: it still looked for an `a[href$="/doorlooptijd"]` and for a visible "Reports" GROUP toggle, and both are deliberately gone. 143 passed, 1 failed, and the one that failed was measuring the IA we had just retired rather than anything broken. The spec now asserts the shape that replaced it: /doorlooptijd is NOT a nav entry, and the Reports footer entry IS present. That second assertion is the one worth having — it is what distinguishes "the reports were regrouped" from "the reports became unreachable", which is the ADR-044 no-functionality-loss guarantee the removal rests on. Matched by text rather than by href, like the Documentation footer link directly below it and for the same measured reason: a section:"footer" entry does not render as a plain top-level anchor the way a nav leaf does. The pages stay routable, so nothing else moved. Every other spec reaches them with a direct GET through navToRoute(), which is why exactly one test failed rather than the dozen that touch these routes.
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 106/106 | |||
| npm | ✅ | ✅ 540/540 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-01 11:28 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
deleted the
fix/navigation-spec-follows-the-reports-page
branch
September 1, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
development E2E is red, and this is why.
dossiq#1583 retired the three report leaves and replaced them with one Reports page of cards (ADR-112).
navigation.spec.tsasserts every nav link it expects, so it went red the moment that merged: it still looked fora[href$="/doorlooptijd"]and for a visible "Reports" group toggle, both deliberately gone.The one that failed was measuring the IA we had just retired, not anything broken.
What the spec asserts now
/doorlooptijdis not a nav entry (removed from the collapsed-leaf list)Reportsis not a group toggle (removed from the group-header list)That last one is what distinguishes "the reports were regrouped" from "the reports became unreachable", which is the ADR-044 no-functionality-loss guarantee the whole removal rests on. Without it the spec would go green on a change that lost the reports entirely.
Matched by text rather than href, like the Documentation footer link directly below it and for the same measured reason: a
section: "footer"entry does not render as a plain top-level anchor the way a nav leaf does.Why only one test broke
The pages stay routable, which is the point. Every other spec that touches them reaches them with a direct GET via
navToRoute()— measured,page-shells,pages,ui-pages,workflow-operationsanddoorlooptijd-dashboardall do — so exactly one test failed rather than the dozen that touch these routes.