Skip to content

fix(e2e): the navigation spec still asserted the Reports submenu - #1617

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/navigation-spec-follows-the-reports-page
Sep 1, 2026
Merged

fix(e2e): the navigation spec still asserted the Reports submenu#1617
rubenvdlinde merged 1 commit into
developmentfrom
fix/navigation-spec-follows-the-reports-page

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

development E2E is red, and this is why.

dossiq#1583 retired the three report leaves and replaced them with one Reports page of cards (ADR-112). navigation.spec.ts asserts every nav link it expects, so it went red the moment that merged: it still looked for a[href$="/doorlooptijd"] and for a visible "Reports" group toggle, both deliberately gone.

1 failed
143 passed (19.6m)
  > 35 | await expect(nav.locator(`a[href$="${href}"]`)).toHaveCount(1)
       - unexpected value "0"

The one that failed was measuring the IA we had just retired, not anything broken.

What the spec asserts now

  • /doorlooptijd is not a nav entry (removed from the collapsed-leaf list)
  • Reports is not a group toggle (removed from the group-header list)
  • the Reports footer entry IS present — a new assertion, and the one worth having

That last one is what distinguishes "the reports were regrouped" from "the reports became unreachable", which is the ADR-044 no-functionality-loss guarantee the whole removal rests on. Without it the spec would go green on a change that lost the reports entirely.

Matched by text rather than href, like the Documentation footer link directly below it and for the same measured reason: a section: "footer" entry does not render as a plain top-level anchor the way a nav leaf does.

Why only one test broke

The pages stay routable, which is the point. Every other spec that touches them reaches them with a direct GET via navToRoute() — measured, page-shells, pages, ui-pages, workflow-operations and doorlooptijd-dashboard all do — so exactly one test failed rather than the dozen that touch these routes.

dossiq#1583 retired the three report leaves and replaced them with one
Reports page of cards (ADR-112). navigation.spec.ts asserts every nav link
it expects, so it went red on development the moment that merged: it still
looked for an `a[href$="/doorlooptijd"]` and for a visible "Reports" GROUP
toggle, and both are deliberately gone.

143 passed, 1 failed, and the one that failed was measuring the IA we had
just retired rather than anything broken.

The spec now asserts the shape that replaced it: /doorlooptijd is NOT a nav
entry, and the Reports footer entry IS present. That second assertion is
the one worth having — it is what distinguishes "the reports were
regrouped" from "the reports became unreachable", which is the ADR-044
no-functionality-loss guarantee the removal rests on.

Matched by text rather than by href, like the Documentation footer link
directly below it and for the same measured reason: a section:"footer"
entry does not render as a plain top-level anchor the way a nav leaf does.

The pages stay routable, so nothing else moved. Every other spec reaches
them with a direct GET through navToRoute(), which is why exactly one test
failed rather than the dozen that touch these routes.
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ c089efe

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue3-compile
test-l10n
format
check-schema-l10n
check-l10n-js
composer ✅ 106/106
npm ✅ 540/540
app:check-code ⏭️
info.xml
REUSE
PHPUnit
Newman ⏭️
Playwright ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development
Hydra gates

Quality workflow — 2026-09-01 11:28 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit dc66f63 into development Sep 1, 2026
49 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/navigation-spec-follows-the-reports-page branch September 1, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant