fix(flow): HermiqFlowResolver.flowsForTrigger used the wrong findAll key - #45
Merged
Merged
Conversation
flowsForTrigger queried `findAll(config: ['register'=>…, 'schema'=>…])`, but OpenRegister's ObjectService::findAll scopes via `config['filters']['register'|'schema']`. The wrong key returned zero objects, so no agentflow wired to an event ever matched — hermiq's event triggers queued nothing. Corrected to `filters`, matching the same fix in OpenRegister's OpenRegisterFlowResolver (openregister#2126). Verified by inspection against ObjectService::prepareFindAllConfig (which reads config.filters.register / .schema); phpcs clean. hermiq CI has no OpenRegister so this OR-referencing class is not analysable there (standing HermiqToolProvider limitation).
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ 1/117 denied | |||
| npm | ✅ | ❌ 1/659 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied composer licenses
| Package | Version | License |
|---|---|---|
| smalot/pdfparser | v2.12.5 | LGPL-3.0 |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| vue3-apexcharts | 1.11.1 | Custom: https://apexcharts.com/media/vue-apexcharts.png |
Quality workflow — 2026-07-25 20:56 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flowsForTriggerqueriedfindAll(config: ['register'=>…, 'schema'=>…]), but OpenRegister'sObjectService::findAllscopes viaconfig['filters']['register'|'schema']. The wrong key returned zero objects, so no agentflow wired to an event ever matched — hermiq's event triggers queued nothing.Corrected to
filters, matching the same fix in OpenRegister'sOpenRegisterFlowResolver(ConductionNL/openregister#2126), where the bug was discovered.Verification
ObjectService::prepareFindAllConfig(which readsconfig.filters.register/.schema). phpcs clean.HermiqToolProviderlimitation).🤖 Generated with Claude Code