feat(nav): give hermiq a Reports page, from the report it already had - #765
Merged
Conversation
ADR-114 Decision 3 puts Reports in every app. Nothing is invented here: AI oversight already existed, and it was an entry in the SETTINGS foldout. That was the wrong home. The foldout is where configuration lives (ADR-044 Decision 3), and oversight is not configuration — it is a reading of what the agents did, which is what a report is. It becomes a card on /reports.⚠️ THE ROUTE HAD TO SURVIVE, AND NOT ONLY FOR DEEP LINKS. dossiq declares /apps/hermiq/ai-oversight as an ADR-110 integrations entry, so retiring the menu entry while dropping the route would 404 from ANOTHER app. The page is untouched, and an e2e test navigates to it directly. Guardrail policy, the algorithm register and Compliance stay in the foldout. Those ARE configuration, and the e2e asserts that asymmetry so a later sweep fails a test rather than passing review. Hermiq is one of only four apps that already had a Store, so its footer now carries all four declared chrome items and the spec asserts the full sequence Documentation, Store, Reports, Features & roadmap. ChartBoxOutline registered in src/icons.js. An unregistered icon name renders no glyph at all — not a fallback, not a console error. Verified: gate-22, gate-53, gate-60, gate-102, gate-104 and gate-107 clean (gate-107 now reports zero warnings for this app, since it has both Store and Reports); prettier clean; all five e2e tests collect.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 3, 2026 17:09
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 123/123 | |||
| npm | ✅ | ✅ 730/730 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred — runs on the promotion into beta/main, not on a pull request into development | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-03 17:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-114 Decision 3 puts Reports in every app. Nothing is invented here — AI oversight already existed, and it was an entry in the settings foldout.
That was the wrong home. The foldout is where configuration lives (ADR-044 Decision 3), and oversight is not configuration: it is a reading of what the agents did, which is what a report is.
dossiq declares
/apps/hermiq/ai-oversightas an ADR-110 integrations entry. Retiring the menu entry while dropping the route would 404 from another app. The page is untouched and an e2e test navigates to it directly.The deliberate asymmetry
Guardrail policy, the algorithm register and Compliance stay in the foldout — those genuinely are configuration. The e2e asserts it, so a later sweep that cards them fails a test rather than passing review.
Full chrome
Hermiq is one of only four apps that already had a Store, so its footer now carries all four declared items and the spec asserts the whole sequence: Documentation, Store, Reports, Features & roadmap. gate-107 reports zero warnings for this app — the first to reach that.
ChartBoxOutlineregistered insrc/icons.js; an unregistered icon name renders no glyph at all.Verified
gate-22, gate-53, gate-60, gate-102, gate-104 and gate-107 clean; prettier clean; all five e2e tests collect.
🤖 Generated with Claude Code